Repository navigation
Conversation
2170cd0 to
c42c932
Compare
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
We should also update UPDATING.md with the change in pruning behavior, since this could break some apps that expect module level pruning - especially where some functions from a module not called directly by the app are expected to be available for use as disterl rpc calls.
We way want to open an issue after this merges to automate the regeneration of src/packbeam_drivers.hrl from the AtomVM repo, so master stays in sync with AtomVM current release branch or main - which is something we will need to decide on since sometimes they diverge quite far.
c42c932 to
50aabee
Compare
Very true. And I realize that what I created didn't match the release branch. Let's use a CI script for this. |
f97d837 to
a2120f2
Compare
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
Since this was a large and complicated PR, I had CodeRabbit do a review and a few things turned up, several of which may need to be checked for validity.
|
We also may want to broaden the test scope to cover any cases that would have failed before these requested changes to prevent any future regression. |
b211b79 to
12d1cfe
Compare
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
12d1cfe to
dded530
Compare
|
I also just realized that I forgot to ask you to update the CHANGELOG, since this is a very significant change =-) |
Works better with atomvm/AtomVM#2404
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later