Repository navigation
Conversation
Constructing a `:16/float` segment rounded halfway values away from zero and truncated subnormals. A tie such as 6546.0 was stored as 6548.0 instead of 6544.0, and 1.0e-6 was truncated instead of rounded, so the bytes differed from BEAM's. Round the discarded bits to nearest, ties to even, in both the normal and subnormal paths. Rounding may now carry from the largest subnormal into the smallest normal number, or round a tie at the bottom of the subnormal range to zero. Fixes: atomvm#2447 Signed-off-by: Peter Madsen-Mygdal <petermm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructing a
:16/floatsegment rounded halfway values away from zero and truncated subnormals. A tie such as 6546.0 was stored as 6548.0 instead of 6544.0, and 1.0e-6 was truncated instead of rounded, so the bytes differed from BEAM's.Round the discarded bits to nearest, ties to even, in both the normal and subnormal paths. Rounding may now carry from the largest subnormal into the smallest normal number, or round a tie at the bottom of the subnormal range to zero.
Fixes: #2447
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later