Skip to content

[PR-7651] Update TCNM to work with two AWS accounts - #81

Merged
Cameronsplaze merged 2 commits into
mainfrom
cjs/tcnm-response-queues
Nov 3, 2026
Merged

Cameronsplaze merged 2 commits into
mainfrom
cjs/tcnm-response-queues

Conversation

@Cameronsplaze

@Cameronsplaze Cameronsplaze commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@Cameronsplaze
Cameronsplaze force-pushed the cjs/tcnm-response-queues branch from b9c597f to f309339 Compare October 29, 2026 06:29
@Cameronsplaze

Copy link
Copy Markdown
Member Author

So I have everything working with NISAR. With the testcnm.cfg and arg:

[nisar-uat]
stack_name = sds-n-cumulus-test
profile = asf-nisar-uat
response_profile = ccumulus
cnsld_stack_name = cnsld-cumulus-uat2
cnm_response_queue = nisar-mock-jpl-queue
pipx run --pip-args=--no-cache-dir --spec ~/Documents/cloud-tools/test-cnm tcnm -e nisar-uat test

All but 4 tests pass, and the failures are related to missing browse images

Totals: 129 Succeeded; 4 Failed; 2 Pending of 135 tests

It seems like for CIRRUS-ASF though, we don't need this update? It's only NISAR? For now at least, CIRRUS-ASF works as-is and you won't want to add these config options to that side's UAT yet.

@Cameronsplaze
Cameronsplaze marked this pull request as ready for review October 29, 2026 06:42
@Cameronsplaze
Cameronsplaze force-pushed the cjs/tcnm-response-queues branch from f309339 to ac3d519 Compare October 29, 2026 06:44
Comment thread test-cnm/test_cnm/tester/executor.py Resolved
Comment thread test-cnm/test_cnm/config.py Resolved
Comment thread test-cnm/test_cnm/config.py Resolved
Comment thread test-cnm/test_cnm/main.py Resolved
Comment thread test-cnm/tests/test_config.py Resolved
@Cameronsplaze
Cameronsplaze force-pushed the cjs/tcnm-response-queues branch 2 times, most recently from 0521d07 to 383f8c2 Compare October 29, 2026 18:45
@Cameronsplaze
Cameronsplaze force-pushed the cjs/tcnm-response-queues branch from 383f8c2 to 3d14fc8 Compare October 29, 2026 18:47
@reweeden

reweeden commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

As for bumping the version number, I'd say this is a backwards compatible change, so 0.10.2

@gjclark

gjclark commented Nov 2, 2026

Copy link
Copy Markdown

I think this looks great Cameron thank you. I have the same sentiment about making it generic and not including any terminology that corresponds directly to our AWS accounts.

@gjclark

gjclark commented Nov 2, 2026

Copy link
Copy Markdown

So I have everything working with NISAR. With the testcnm.cfg and arg:

[nisar-uat]
stack_name = sds-n-cumulus-test
profile = asf-nisar-uat
response_profile = ccumulus
cnsld_stack_name = cnsld-cumulus-uat2
cnm_response_queue = nisar-mock-jpl-queue
pipx run --pip-args=--no-cache-dir --spec ~/Documents/cloud-tools/test-cnm tcnm -e nisar-uat test

All but 4 tests pass, and the failures are related to missing browse images

Totals: 129 Succeeded; 4 Failed; 2 Pending of 135 tests

It seems like for CIRRUS-ASF though, we don't need this update? It's only NISAR? For now at least, CIRRUS-ASF works as-is and you won't want to add these config options to that side's UAT yet.

I definitely think you would need it for both.

@Cameronsplaze
Cameronsplaze merged commit 59f9312 into main Nov 3, 2026
11 checks passed
@Cameronsplaze
Cameronsplaze deleted the cjs/tcnm-response-queues branch November 3, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants