Repository navigation
Drawer polish: recording controls, header chips, info section, flags and endpoint restarts - #16
Merged
Merged
Conversation
…ghter spacing and text
…fig check, clamped recording bar, docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Drawer improvements from hands-on testing on small phones:
restartOnChangeoronChangedalready applies it.BuildConfig, debuggable, R8 state, SDK levels) and Device info, withInfoPlugin(appInfo, deviceInfo)switches.AppearancePlugin(localeSettings)).Public API stays compatible with 1.0.0: new constructor parameters come with hidden overloads of the old constructors (
apiCheckand the.apidiff show only additions).How it was tested
./gradlew ktlintFormat ktlintCheck lintDebug lintRelease testDebugUnitTest assembleDebug assembleRelease publishToMavenLocal apiCheck :sample:assembleQapasses.onChanged, BuildConfig from other modules, unbounded recording bar, missing switches, docs) are fixed in the last commit.Checklist
CHANGELOG.md(or theskip-changeloglabel is set)./gradlew ktlintFormat ktlintCheck lintDebug testDebugUnitTestpasses