Skip to content

fix(desktop): stop marking a plan step as running once the plan has stopped - #6496

Merged
M4n5ter merged 1 commit into
rust-previewfrom
fix/desktop-plan-stopped-step
Oct 31, 2026
Merged

M4n5ter merged 1 commit into
rust-previewfrom
fix/desktop-plan-stopped-step

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Follow-up to #6494. When a Plan execution stops (cancelled, interrupted, completed) while the model still has a step marked in_progress, the card kept showing that step with the running icon and accent colour. The step now shows as a plain unchecked step once the execution is no longer awaiting admission or active.

The terminal component test now cancels the running Plan and checks that the running glyph is gone. Without the fix, that assertion fails.

AI use

  • Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code wrote the change and this description; its commit carries Generated-by: Claude Code.

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review notice: This comment was posted by an automated review agent. It is not an independent human review and does not replace one.

I reviewed all three changed files at 206a0379e63c99c0038b5f0b004075f3c1f9ef7f, plus the surrounding Plan panel and its action routing. The previous statusOf returned a stored in_progress step even after its execution had stopped; that value directly selected the activity icon and accent color. Mapping it to pending for stopped executions fixes that display without changing stored progress or Host execution.

I found no confirmed P0–P2 in this scope. Ten checks of the unmodified production live, panel-selection and statusOf functions passed with controlled Plan data and computed values; the same checks against the previous implementation failed four cases. They cover cancelled, interrupted and completed executions, both active phases, preserved completed/skipped steps, missing status, proposal precedence, and cancellation remaining active until the execution actually stops. Both changed TSX files also parsed successfully, and git diff --check passed. I read the extended cancellation fixture and native glyph assertion but did not execute the Rust/NSH test, render the panel, or exercise a real Host cancellation.

No Host wire format or storage migration changes. The actual merge with rust-preview at 0d5e27d381086c5b9b374775878e3202afaffc4a is clean. This PR's CI is still running. A completed Rust-base run at 3100eeecd failed on clippy::collapsible_if in platform/computer-use/src/browser.rs:789; that source is unchanged by this PR. That existing failure does not establish a new defect here, and the current checks are not yet a successful validation.


Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.

@M4n5ter
M4n5ter merged commit f3ec828 into rust-preview Oct 31, 2026
1 of 2 checks passed
@M4n5ter
M4n5ter deleted the fix/desktop-plan-stopped-step branch October 31, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants