HBASE-23996 Add metric for the split WAL procedure - #8515
Open
Umeshkumar9414 wants to merge 3 commits into
Open
Conversation
Umeshkumar9414
force-pushed
the
HBASE-23996_split_wal
branch
from
July 30, 2026 08:45
c3b3ed4 to
bf73a3d
Compare
Assert the new splitWAL procedure metric in two places: TestMasterMetrics#testDefaultMasterMetrics (splitWALSubmittedCount is registered and reads 0 at rest) and TestSplitWALManager#testSplitLogs (increments by one per SplitWALProcedure, verified against a captured baseline on the procedure-based non-ZK split path). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Mark the legacy ZooKeeper-coordinated WAL split coordination classes (ZKSplitLogManagerCoordination, ZkSplitLogWorkerCoordination) and the associated MetricsMasterFileSystem source as deprecated, since the procedure-based distributed WAL splitter (SplitWALManager) is the default and these are only reachable under the legacy hbase.split.writer.coordinated.by.zk path. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Umeshkumar9414
force-pushed
the
HBASE-23996_split_wal
branch
from
July 30, 2026 08:48
bf73a3d to
4bff3da
Compare
virajjasani
self-requested a review
August 11, 2026 04:37
There was a problem hiding this comment.
Pull request overview
Adds master metrics for procedure-based WAL splitting and deprecates metrics and coordination classes tied to the legacy ZooKeeper flow.
Changes:
- Adds submitted, failed, and timing metrics for
SplitWALProcedure. - Verifies metric registration and submission counts.
- Marks legacy ZooKeeper WAL-splitting components as deprecated.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java |
Tests split-WAL submission metrics. |
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetrics.java |
Verifies default metric registration. |
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALProcedure.java |
Connects the procedure to its metrics. |
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFileSystem.java |
Deprecates legacy filesystem metrics. |
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMaster.java |
Exposes split-WAL procedure metrics. |
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordination.java |
Deprecates legacy worker coordination. |
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java |
Deprecates legacy manager coordination. |
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSourceImpl.java |
Registers split-WAL operation metrics. |
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterSource.java |
Defines the metric prefix and accessor. |
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFilesystemSourceImpl.java |
Deprecates the legacy metrics implementation. |
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterFileSystemSource.java |
Deprecates the legacy metrics interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
apurtell
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have deprecated HBASE_SPLIT_WAL_COORDINATED_BY_ZK but some Classes only used by that flow was not marked deprecated. I have marked those deprecated in this PR only. I hope that is fine else I will create another PR for that.
Some screen shots for the old metrics and the new one.
example 1
example 2
Old one