[test] Stabilize RemoteLogDownloader prefetch test - #3968
Open
void-ptr974 wants to merge 1 commit into
Open
Conversation
Pause the downloader fetch loop before asserting recycled prefetch permits so the background thread cannot consume a permit concurrently.
void-ptr974
changed the title
void-ptr974
marked this pull request as ready for review
August 12, 2026 14:56
Jackeyzhe
reviewed
Aug 13, 2026
| void fetchOnce() throws Exception { | ||
| // Pause after all requests are scheduled so the loop cannot acquire a | ||
| // recycled permit before it is asserted below. | ||
| if (scannerMetricGroup.remoteFetchRequestCount().getCount() >= 5) { |
Contributor
There was a problem hiding this comment.
Nice fix, nit: I think extracting 5 as a named constant (e.g. EXPECTED_COUNT) or a variable would be reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3460
RemoteLogDownloaderTest.testPrefetchNumcan observe one available prefetch permit instead of two because the downloader thread may acquire a recycled permit while polling the empty request queue.Brief change log
Tests
mvn -pl fluss-client -am -Dtest=RemoteLogDownloaderTest#testPrefetchNum -Dsurefire.failIfNoSpecifiedTests=false testRemoteLogDownloaderTest#testPrefetchNum10 times.mvn -pl fluss-client -am verify(blocked by unrelated local JMX/RMI connection failures inJMXServerTestandJMXReporterTest).API and Format
No API or storage-format changes.
Documentation
No documentation changes.
Generative AI disclosure