[rust] Validate append_arrow_batch nullability before enqueue - #3950
Open
charlesdong1991 wants to merge 1 commit into
Open
[rust] Validate append_arrow_batch nullability before enqueue#3950charlesdong1991 wants to merge 1 commit into
charlesdong1991 wants to merge 1 commit into
Conversation
charlesdong1991
commented
Aug 11, 2026
|
|
||
| #[derive(Default)] | ||
| pub struct PrebuiltRecordBatchBuilder { | ||
| pub(crate) struct PrebuiltRecordBatchBuilder { |
Contributor
Author
There was a problem hiding this comment.
IMHO, i don't think this should be a public api in the first place
Contributor
Author
|
cc @leekeiabstraction @fresh-borzoni PTAL thanks in advance!! 🙏 |
leekeiabstraction
left a comment
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR. Left a comment
| } | ||
|
|
||
| #[test] | ||
| fn prebuilt_builder_rejects_nulls_in_not_null_column() { |
Contributor
There was a problem hiding this comment.
Can you also add test cases for nested types?
Contributor
Author
There was a problem hiding this comment.
i thought i left a comment that it doesn't support nested type because IIUC, java side doesn't work with nested types either based on code 🤔 i didn't have time to do an end-to-end run on Java yesterday because our PoC was for python...
i will check today and confirm if that is the case, and create an issue for Java if so...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3949
Brief change log
append_arrow_batchcan accept a caller-provided ArrowRecordBatchwhere a NOT NULL Fluss column contains null values. The write is accepted in some paths and the failure appears later during decode/scan.Tests