Repository navigation
chore!: clean up the repository for v2 and release on every merge - #10
Merged
Merged
Conversation
- Remove the unused check-file-change and check-comments hooks and the Python packaging - Move check-branch-name to hooks/, unchanged, and test it with bats - Replace the Aqua scanner, now handled by Wiz, with CI running shellcheck, zizmor and the hook tests - Publish a vX.Y.Z release on every merged PR, bumped by its required release label - Document usage in README.md and contributing in CONTRIBUTING.md - Keep dependencies up to date with Renovate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oscar-alma
added
the
release:major
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Print a deprecation notice from the hook, and mark it deprecated in its name and in the README - Point to a "Restrict branch names" ruleset rule as the replacement - Simplify README.md and CONTRIBUTING.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Add uv-lock-script from alma/actions#269 (DEX-1156): keeps the lock files of PEP 723 scripts up to date, and fails while a lock file isn't tracked by git - Remove check-branch-name: use a GitHub "Restrict branch names" ruleset instead (DEX-2659) - Run CI on ubuntu-26.04 and move the Renovate config to .github/ Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Matching lock files only covered lock-only changes, which CI (--all-files) and `uv run --locked` already catch. Also document that a lock file not added to git fails the hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An up-to-date lock is checked offline and never upgraded, so running the hook on --all-files doesn't touch main or CI. Also fix write_script, which wrote an unquoted dependency: the "can't be locked" tests failed on a TOML error instead of the offline resolution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Starting one grep per file made --all-files take 3.7 s on a 7,043-file repository. A single grep -l brings it to 0.5 s. Add BENCHMARKS.md with the hook's benchmark and how to run it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A separate benchmark file nobody can rerun would go stale. Keep only the result, where consumers choose the hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
remi-zuffinetti
approved these changes
Oct 29, 2026
remi-zuffinetti
left a comment
remi-zuffinetti
left a comment
Contributor
There was a problem hiding this comment.
TIL, bats.
As a follow-up, you may want to install it (and maybe prek?) with mise and a lockfile, so that we do not depend on a new 3rd-party Github Action. But this is not a requirement.
Replace bats-action, setup-uv and prek-action with mise-action, already used across the org, and pin the tools with their checksums in mise.lock. Contributors get the same versions with `mise install`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
uv-lock-scripthook here from alma/actions#269 (DEX-1156). This repository is public, so anyrepository can use its hooks without credentials.
Changes
check-file-changeandcheck-comments(no users in the org) and the Python packaging.uv-lock-script: imported from alma/actions#269. Tested with bats, offline.check-branch-name: removed. Replace it with a GitHub "Restrict branch names" ruleset; DEX-2659 tracksmigrating its 10 users.
vX.Y.Zrelease. The bump comes from exactly one requiredlabel:
release:major,release:minor,release:patchornorelease. There's no floating major tag, becausepre-commit caches each
revforever.releasing, what counts as breaking), written for outside contributors.
norelease.🤖 Generated with Claude Code