Repository navigation
chore(hooks): expose dependency preparation for agent commands - #714
Merged
Merged
Conversation
|
umm-actually re-reviewed at No new findings (4 tracked finding(s) across all runs). umm-actually · z-ai/glm-5.3-flash |
Ship-Check: code-quality · gpt-6.1-sol
Ship-Check: test-audit · gpt-6.1-sol
Ship-Check: pr-monitor · gpt-6.1-sol
Ship-Check: triage · gpt-6.1-sol
Ship-Check: triage · gpt-6.1-sol
Use direct argv execution in the physical-runtime fixture while retaining outside-checkout Node ABI and npm PATH checks. Ship-Check: pr-monitor · gpt-6.1-sol
Owner
Author
|
Review pipeline complete for da2051c.
Sweep receipts: both operation interfaces now reject trailing arguments; a repo-wide search found seven Bash spawn sites, and the one unnecessary dynamic-argument shell fixture was replaced with direct Node/npm argv. The six remaining calls use fixed shell programs or script-file argv. Node fallback and output-validation guidance have one procedural home in CONTRIBUTING, reached by AGENTS.md. Verdict: merge-ready. The maintainer controls the merge. 🔍 ship-check · ship-check · gpt-6.1-sol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh agent worktrees need dependency setup and the same Node runtime for installation and execution. Add an opt-in repository command interface:
environmentselects the physical Node bin;preparealso waits for the existing dependency and SST installer. Invalid operations and extra arguments are rejected. Explicit operations report an unresolved checkout as failure, while ordinary Claude hooks keep their current skip behavior.The installer retains its locking, retry and install-ownership behavior. The contributor guide documents invocation, output validation and Node fallback; AGENTS.md links to it within the instruction budget. Shared Codex/OpenCode adapter integration is maintained separately in private tooling.
Validation at da2051c: all CI checks green, including amd64/arm64 smoke tests; 6,093 tests passed and one skipped. Build, types, Knip, ESLint, ShellCheck, Markdown lint and formatting pass. Native Codex/OpenCode fixtures verified automatic setup, Node 24.18.0 / ABI 137, repeat behavior and preserved permission boundaries. The required review pipeline and substantive delta reviews are complete; all six bot threads are resolved and the latest bot pass has no new findings.
🔍 ship-check · ship-check · gpt-6.1-sol