Skip to content

chore(hooks): expose dependency preparation for agent commands - #714

Merged
aliasunder merged 7 commits into
mainfrom
feat/agent-worktree-dependencies
Oct 26, 2026
Merged

aliasunder merged 7 commits into
mainfrom
feat/agent-worktree-dependencies

Conversation

@aliasunder

@aliasunder aliasunder commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Fresh agent worktrees need dependency setup and the same Node runtime for installation and execution. Add an opt-in repository command interface: environment selects the physical Node bin; prepare also waits for the existing dependency and SST installer. Invalid operations and extra arguments are rejected. Explicit operations report an unresolved checkout as failure, while ordinary Claude hooks keep their current skip behavior.

The installer retains its locking, retry and install-ownership behavior. The contributor guide documents invocation, output validation and Node fallback; AGENTS.md links to it within the instruction budget. Shared Codex/OpenCode adapter integration is maintained separately in private tooling.

Validation at da2051c: all CI checks green, including amd64/arm64 smoke tests; 6,093 tests passed and one skipped. Build, types, Knip, ESLint, ShellCheck, Markdown lint and formatting pass. Native Codex/OpenCode fixtures verified automatic setup, Node 24.18.0 / ABI 137, repeat behavior and preserved permission boundaries. The required review pipeline and substantive delta reviews are complete; all six bot threads are resolved and the latest bot pass has no new findings.


🔍 ship-check · ship-check · gpt-6.1-sol

Comment thread src/__tests__/install-deps.test.ts Fixed
Comment thread .claude/hooks/install-deps.sh
Comment thread AGENTS.md Outdated
Comment thread src/__tests__/install-deps.test.ts
@umm-actually

umm-actually Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

umm-actually re-reviewed at da2051c

No new findings (4 tracked finding(s) across all runs).


umm-actually · z-ai/glm-5.3-flash

Ship-Check: code-quality · gpt-6.1-sol
Ship-Check: test-audit · gpt-6.1-sol
Comment thread .claude/hooks/prepare-command.sh
Comment thread src/__tests__/install-deps.test.ts Fixed
Ship-Check: triage · gpt-6.1-sol
Use direct argv execution in the physical-runtime fixture while retaining outside-checkout Node ABI and npm PATH checks.

Ship-Check: pr-monitor · gpt-6.1-sol

Copy link
Copy Markdown
Owner Author

Review pipeline complete for da2051c.

  • CI: all checks green, including amd64/arm64 smoke tests; 6,093 tests passed and one skipped across 122 passing test files.
  • Bot review: all six inline threads resolved; the latest umm-actually pass reports no new findings. CodeQL marks both reported test alerts fixed. Review bodies contain no additional findings; the single non-pipeline issue comment is the evaluated bot status.
  • Coverage: dedicated PR, fresh-eyes, code-quality, test-audit and bug passes completed. Whole-change design covered all seven files with none missed. Later logic/test changes received independent delta bug, quality and test review with zero findings; the final reviewed SHA equals the PR head.
  • Design disposition: retained the explicit no-checkout failure status. Direct command callers need that signal independently of stdout validation; ordinary Claude skip behavior is preserved.
  • Native validation: Codex and OpenCode checks verified setup and matching Node 24.18.0 / ABI 137, preserved native permissions, and repeated commands without reinstalling.

Sweep receipts: both operation interfaces now reject trailing arguments; a repo-wide search found seven Bash spawn sites, and the one unnecessary dynamic-argument shell fixture was replaced with direct Node/npm argv. The six remaining calls use fixed shell programs or script-file argv. Node fallback and output-validation guidance have one procedural home in CONTRIBUTING, reached by AGENTS.md.

Verdict: merge-ready. The maintainer controls the merge.


🔍 ship-check · ship-check · gpt-6.1-sol

@aliasunder
aliasunder merged commit 16d466f into main Oct 26, 2026
18 checks passed
@aliasunder
aliasunder deleted the feat/agent-worktree-dependencies branch October 26, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants