Repository navigation
test: remove unused imports and variables flagged by ruff - #190
Merged
Merged
Conversation
Fixes 8 pre-existing ruff findings in test/ that CI lint does not cover (it only checks flickr_api/): 6x F401 (unused flickr_api / MagicMock imports) and 2x F841 (unused args dict in request tests, where the dict is passed as a keyword argument instead). No behavior change; full suite passes (324 passed, 2 skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up 8 pre-existing ruff findings in
test/that CI lint does not gate (the CI lint job only checksflickr_api/):import flickr_api as fintest_activity.py,test_bytes_response.py,test_commons.py,test_urls.py,test_walker.py, and unusedMagicMockintest_rate_limit.py/test_walker.py.args = dict(...)assignments intest_500_handler.pyandtest_bytes_response.py— the request is made via keyword arguments, so the dict was dead code.No behavior change. Full suite passes locally (324 passed, 2 skipped);
ruff check test/is now clean.