Skip to content

docs: correct runner drain and worker guidance - #227

Merged
indykish merged 1 commit into
mainfrom
chore/m230-astra-docs-corrections
Oct 24, 2026
Merged

indykish merged 1 commit into
mainfrom
chore/m230-astra-docs-corrections

Conversation

@indykish

@indykish indykish commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Session notes 1

Runner guidance now warns that Cordon and Drain block renewals and completion reports. Lowering Workers below current usage can also block renewals.
Wait for work to finish and report before changing these controls. This follows the architecture review for product PR #784.

Review

Astra reviewed the corrected page against authentication and capacity source. No findings remain after correcting the Workers warning. The independent adversarial pass was completed in-host; outside-provider review was disabled.

Make

Local verification on commit 9c35f74:

  • make test: exit 0; 25 tests passed; Documentation check passed.
  • bun run orly gate verify: exit 0; changed documentation prose is clean; build validation passed; no broken links found.
  • gitleaks git --log-opts='origin/main..HEAD' --redact --no-banner: exit 0; 1 commit scanned; no leaks found.

Documentation

Status: current. The corrected runner warnings match the authorized static source; no further factual correction was identified.

Audited scope: one unstaged change in runners.mdx against 017c77c969d1389150947500231151bdf82bc22a; no committed, staged, or new-file changes. Reviewed the full runner and installation pages, related fleet lifecycle pages, runner error reference, repository instructions, navigation and build configuration.

Documentation health:

  • runners.mdx: Current; Cordon/Drain request blocking and Workers renewal risk are explicit.
  • runners/install.mdx: Current for this change; no conflicting drain instructions.
  • fleets/running.mdx and fleets/overview.mdx: Current for this change; fleet lifecycle controls remain distinct.
  • api-reference/error-codes.mdx: Current in the reviewed runner section; UZ-RUN-009 agrees with blocked access.
  • README.md, CONTRIBUTING.md, AGENTS.md and docs.json: Current for this change; runner pages are discoverable through the configured Runner operations navigation.
  • ARCHITECTURE.md and TODOS.md: Skipped; absent.
  • changelog.mdx: Skipped; protected historical release content is outside this child audit.

Coverage debt: no critical or reference-only gap introduced. The runner explanation includes state and Workers reference plus operational instructions; the nested installation how-to remains available. No new tutorial is required for this correction. Diagram drift: none found in the reviewed scope; no relevant diagrams or renamed entities changed.

Evidence limits: static source/document reads only; no tests, gates, live behavior, or outside-provider coverage. Unchanged implementation details elsewhere on the runner page were not independently revalidated. Existing older metadata on the installation page was preserved. Separate native in-host adversarial review found no additional supported factual issue.

Test plan

  • Documentation tests, build validation, and link checks.
  • Static comparison with runner authentication and capacity source.
  • Post-push checks and review follow-up.

RetriggerView in GreptileConfidence Score: 5/5

This documentation change appears safe to merge.

Summary

Updates runners.mdx to correct runner shutdown and worker-count guidance.

  • Runner guidance warns operators before controls can interrupt active work.

No actionable issues were found.

Reviews (1) · Last reviewed commit: "docs: correct runner drain and worker gu..." · Reviewed by Greptile

@indykish
indykish merged commit 879ca12 into main Oct 24, 2026
4 checks passed
@indykish
indykish deleted the chore/m230-astra-docs-corrections branch October 24, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant