Repository navigation
fix(workflow): preserve complete tool results - #355
Open
PoisonGodv wants to merge 1 commit into
Open
PoisonGodv wants to merge 1 commit into
PoisonGodv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I acknowledge this contribution to ARGI.
Describe what this PR does / why we need it
Preserve empty, composite, JSON, binary and metadata-bearing successful tool results instead of truncating them to the first text or producing null step outputs; retain ordinary single-text string compatibility.Does this pull request fix one issue?
Fixes #281.Describe how you did it
Project complete results into ordered, path-addressable maps/lists and move successful result validation, projection and publication outside invocation retries so result-handling failures cannot replay an already successful tool effect; keep invocation failures and error ToolResult retries. Document downstream paths, migration and runtime boundaries.Describe how to verify it
The unchanged reviewed implementation passesmvn -B -pl :argi-workflow-core -am clean test: 142 tests, zero failures/errors/skips and zero Checkstyle violations; the same 12-case regression suite produces 2 failures and 7 errors on the baseline. Four independent offline probes pass, covering following-tool mappings, failed-stage retry, cancellation between attempts and parallel outputs. Pinned Java formatting, fullmake lint, fullmake licenses-check(1043 valid, 634 ignored, zero invalid) and diff whitespace checks pass.Special notes for reviews
A metadata-bearing single-text result intentionally becomes structured; consumers selecting its text should usecontent.0.text. JSON text is preserved rather than parsed; binary argument serialization follows the configured ObjectMapper. The composite representation is proposed for maintainer review. Whole-repository tests, real providers and end-to-end multimodal adapters were not run; failed invocations may already have external effects, so this is not an exactly-once guarantee. AI-assisted implementation and independent local review.