[bokelley]

Part of #1695, slice 4 (managed delivery): 4a2, production composition on the memory store, following adcontextprotocol/adcp-client#3523. It stacks on #1731 and everything below it. Review only feat(reporting): deliver reporting subscriptions through production managed delivery.

ReliableReportingService(production=..., reporting_subscriptions=ReportingSubscriptionServiceOptions(..., bind_managed_generation=...)) now delivers subscriptions through the production profile. This PR covers the memory store; PostgreSQL is 4b.

Destination binding (TS: "binding comes first")

• Bound once: bind_managed_generation(configuration, version) is called once per (version, offering) generation, before that generation's first obligation is written. It is never called again for an admitted generation.
• What the host does: it resolves the version's destination.destination_id to the owner's current destination generation, authorizes it for the account and returns the ReportingDestinationBinding. Per-account authorizations of a shared destination_ref are therefore the host's.
• Checks: the SDK requires the binding to be this generation's, with the version destination's path_template. It then admits the generation and activates the account like sync_accounts admission.
• Failure: a failed bind writes nothing, and the next turn retries.

Constituents frozen per obligation (TS: "each obligation freezes its own denominator")

• Freezing at planning: an owed set has no generation-wide denominator. At planning, each obligation freezes the constituents of exactly its media buys from the source's current configuration_binding(configuration) (the host's authorized pool). It is committed atomically with them (commit_subscription_obligation).
• Outside the pool: a media buy the pool lacks fails that subscription's planning for the turn, and nothing is written.
• Dispatch and publication: the frozen constituents must still lie within the current pool. That's a subset rule instead of the account generation's exact match, and ReportingProductionSourceBinding.check skips the generation media-buy equality for owed sets.
• Planner changes: a commit hook; the install hook receives the version's configuration; obligations are created at the planning horizon.

Production turn

• Each production turn first plans every listed principal's owed sets, then runs each producer's owed sets after its leased work.
• Owed sets are never leased. One owed set's failure is logged and never stops another or the turn.
• Admission and the materializer's admission context accept an owed set through _subscription_offering. It checks the generation's resolved offering, contract, finality, definition and binding, with no grid or generation-wide denominator.
• An owed obligation is materialized whatever the subscription's later state. The inactive parking applies only to account generations.

Authority and requests

• The production materializer is composed with authorize_subscription_delivery = engine.authorizes_delivery (feat(reporting): subscription rows carry account_id and delivery re-checks authority #1731). A lost grant holds the delivery; a re-grant delivers it (tested).
• The mounted production handler checks get_reporting_status, exact reads, sync_reporting_status and sync_reporting_receipts against the grant (feat(reporting): check reporting tasks against the current subscription grant #1728). It adds subscription_coverage to status reads.

Still refused

• Receipt-reconciled (consumer_receipt) subscription offerings: refused at validation.
• PostgreSQL production stores: refused at startup until 4b adds:
  • per-obligation constituents;
  • owed-set enrollment;
  • lifting feat(reporting): hold reporting-subscription owed sets in the PostgreSQL ledger #1729's account-only CHECKs on the production, materializer and reconciliation tables.

Tests

tests/conformance/reporting/test_reporting_subscription_production.py uses the memory production profile with the SQLite destination fixture. It uses a verifier whose row schema admits account_id (built in the test; the shipped reference definition is unchanged).

• End to end: the generation is bound once; two owed obligations are frozen with exactly their buys, produced and materialized; delivered rows carry account_id; status reports offering_id; a second turn binds nothing.
• Outside the pool: a buy outside the authorized pool fails that subscription's planning and writes nothing.
• Lost grant: revoking the grant holds the next delivery under the same identity, refuses sync_reporting_status, and a re-grant delivers it.
• Regression: all reporting suites pass locally (except wheel-building packaging tests, which need more disk than the sandbox has).

This does not adopt beta.2.

🤖 Generated with Claude Code

[aao-secretariat]

Ladon verdict: Approve

Approve — new production composition for reporting-subscription managed delivery on the memory store, with a 445-line conformance test backing the load-bearing invariants.

Decision trace (top-down):

• Row 1 (critical/high): no blocking findings. Reviewer verified binding-once + idempotent admit, per-obligation constituent freeze (buy-outside-pool fails planning and writes nothing, tested L411), owed-set exemption from the generation-wide denominator at both the lenient store check and strict dispatch re-check, lost-grant holds delivery under the same identity with re-grant delivering (tested L420), grant checks on all four production tasks, coverage gated by serves_subscriptions. PostgreSQL and receipt-reconciled offerings correctly refused.
• Row 2 (gated_paths): false, N/A.
• Row 3/5 (high_risk deleted/modified+medium): high_risk is true via src/adcp/decisioning/handler.py (modified), but the single medium finding lands in src/adcp/reporting/production/service.py — NOT on the modified high-risk file. Row 5 requires the medium to coincide with the modified high-risk file; it does not. No deletions. Neither row fires.
• Row 4 (medium + data-loss/schema/infra): the one medium is an observability/diagnostics gap (owed-set run failure logs only the exception type, bypassing the worker's structured diagnostics signals) — not data-loss/schema/infra category. Does not fire.
• Row 6: no prior decision.
• Row 7: no no-auto-approve team match.
• Row 8: only 1 medium finding (< 3).
• Row 9: approve.

Medium finding (non-blocking):

• src/adcp/reporting/production/service.py:766 — Owed-set run failure logs only the exception type via the plain module logger, bypassing the worker's _diagnostics closed signals; a persistently failing subscription delivers nothing with no structured operator signal. Worth a follow-up to route through _diagnostics, but a single observability gap does not block.

Medium findings

• src/adcp/reporting/production/service.py:766 — Owed-set run failure logs only the exception type, bypassing the worker's diagnostics signals

[aao-secretariat]

Ladon verdict: Approve

Approve.

This is a subsequent review following a prior approve. The developer's delta resolves the single prior Medium finding (service.py:766 — owed-set run failures logged only the exception type, bypassing the worker's diagnostics signals). _run_owed_sets now aggregates per-turn owed-set failures into one closed REPORTING_PRODUCTION_OWED_SET_FAILED diagnostics signal via _owed_sets_failed, mirroring _maintenance_failed exactly (closed code, two integer counters, type() is int guards, no identifier/exception/message leak, broad except around handle). A test covers isolation, no-secret-leak (exc_info is None), and the quiet healthy path.

Gate checks:

• No no-auto-approve team match (HARD RULE N/A).
• gated_paths: false, and review_decision: APPROVED anyway (HARD RULE N/A).
• No critical/high findings (row 1 N/A).
• high_risk: true but the only high-risk reason is src/adcp/decisioning/handler.py (modified) with no medium-or-higher finding on it (rows 3, 5 N/A).
• No medium findings at all in this run (rows 4, 8 N/A).
• Prior decision was approve, not escalate (row 6 N/A).

No current findings. Falls through to row 9 → approve.