[upstream] [TASK] Keep the docheader navigation row sticky - #19
Open
github-actions[bot] wants to merge 1 commit into
Open
[upstream] [TASK] Keep the docheader navigation row sticky#19github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
The module docheader consists of a navigation row (content navigation toggle, breadcrumb, language selector) and the button bar. Only the button bar was sticky, so the navigation row scrolled out of the viewport and stayed gone for the rest of the editing session. Both rows are now wrapped in a sticky container, keeping breadcrumb and language selector reachable while working in long lists. On very small viewports the container scrolls up by the height of the navigation row, which preserves the previous behaviour there. Both bars wrap, so how much of the docheader stays pinned is a runtime value rather than a fixed one. A resize observer publishes the measured heights as CSS custom properties, and the sticky offset as well as everything pinned below the docheader offsets against those. Resolves: #110390 Releases: main, 14.3 Change-Id: I7a36a3643b0f9a727ad5285e1a636957d1766867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/95218 Tested-by: core-ci <typo3@b13.com> Tested-by: Garvin Hicking <garvin@hick.ing> Reviewed-by: Garvin Hicking <garvin@hick.ing> (cherry picked from commit 892043ed97d4e29a8b5386980067bf46fc72b38e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatisch vorgeschlagener Cherry-pick aus TYPO3-CMS/form @ 14.3.
Upstream-Commit
892043ed97d4e29a8b5386980067bf46fc72b38eCommit-Message
Upstream-Commit-Message anzeigen
Erzeugt von
.github/workflows/upstream-sync.yml.Um diesen Commit künftig nicht erneut vorzuschlagen, schließe die PR ohne Merge — der Marker unten bleibt erhalten.