Repository navigation
Regenerate the tool docs for 20.8.2 - #1009
Merged
Merged
Conversation
DefinitionsTest.WriteFoundTools writes the viewer's scanned paths with this library's version in the NuGet cache folder, and the committed include still named 20.7.1 while Directory.Build.props is at 20.8.2, so every local test run left it modified. docs/diff-tool.md is regenerated from it by MarkdownSnippets.
SimonCropp
added a commit
that referenced
this pull request
Oct 30, 2026
The viewer is looked for in the NuGet cache under this library's own version first, and WriteFoundTools wrote that path as it was, so diffTools.include.md and docs/diff-tool.md went stale at every release (#1009 caught them up from 20.7.1). The writer now shows that segment as {version}, and the docs change only when the search order does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefinitionsTest.WriteFoundToolswritessrc/DiffEngine.Tests/diffTools.include.md, and the viewer's scanned paths in it name this library's NuGet cache folder by version (FallbackViewerDirectories.LibraryVersion). The committed copy still named 20.7.1 whileDirectory.Build.propsis at 20.8.2, so every local test run left it modified.The change. The include regenerated by the tests, and
docs/diff-tool.mdregenerated from it by MarkdownSnippets. Each changes six lines, the win-x64, osx-x64 and linux-x64 cache paths, from 20.7.1 to 20.8.2.Tests. Locally on Windows, a Release build had no errors. DiffEngine.Tests: 2,264 passed, 20 skipped, 4 failed. The failures are
AListenerIsFoundOnItsPortandAListenerIsListedOnEveryPlatformon net10 and net48. Both assertListenerTable.Enumerated, the .NET fallback built onGetActiveTcpListeners, which misses listeners on this machine's Windows build (10.0.26300). CI passes them on main.