Repository navigation
parser - Issue #202(API tools) - #214
Open
Sidd-Pelluru wants to merge 3 commits into
Open
Sidd-Pelluru wants to merge 3 commits into
Sidd-Pelluru wants to merge 3 commits into
Conversation
…based test cases with slices of structs so test order is deterministic.
…-based fails and TestParseTimeOrPanic cases with slices of structs that have a Name field, so test order is deterministic and changed syntax in the loops after changing from map to slice and removed the fmt package which was used to make names for unnamed test cases and updated code gets the name from the struct instead as go treats unused imports as errors
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…based test cases with slices of structs so test order is deterministic.
Description
worked on issue #202 which was changing from a map to a slice to make it more deterministic
Testing
To test it:
Check out the branch:
git fetch origin
git checkout 202-improve-unit-tests-in-sectionparser_testgo
Run the parser tests:
go test ./parser/... -v or go test ./... -v
Confirm the expected result:
garbage_in_garbage_out) show as named subtests
AI Disclosure
Came up with how I thought I could do it and just asked AI to review it without chaining my version and giving any hints or generating the code for me
Checklist