Skip to content

fix: input in create link button popover closing keyboard - #2982

Draft
matthewlipski wants to merge 2 commits into
mobile-toolbar-demofrom
toolbar-chrome-android-fix
Draft

fix: input in create link button popover closing keyboard#2982
matthewlipski wants to merge 2 commits into
mobile-toolbar-demofrom
toolbar-chrome-android-fix

Conversation

@matthewlipski

@matthewlipski matthewlipski commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes an issue where tapping the create link button in the formatting toolbar on Android Chrome closes the virtual keyboard as well as the toolbar. The reason this happens is that tapping the button opens a popover, which immediately gets autofocused. Chrome on Android bugs out when there's not a certain amount of space below an input in a popover, making the virtual keyboard open and immediately dismiss when tapping the input, or focusing it in any other way:

1000001130.mov

This is fixed in the PR by calling scrollIntoView on the input just before the focus moves to it. However, it messes up the scroll position in the document. I've tried resetting the scroll position back to the selection using scrollTo and transaction.scrollIntoView in a timeout, but couldn't get this working.

The issue is reproducible on BrowserStack - you should be able to compare the previews of this PR and #2939 side-by-side.

Rationale

Changes

Impact

Testing

Screenshots/Video

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

Additional Notes

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blocknote Ready Ready Preview Aug 18, 2026 2:13pm
blocknote-website Ready Ready Preview Aug 18, 2026 2:13pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c1cc9ac2-b108-4d6d-8759-e8f5ad75b4e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthewlipski matthewlipski changed the title Fixed input in create link button popover closing keyboard. fix: input in create link button popover closing keyboard Aug 18, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@2982

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@2982

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@2982

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@2982

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@2982

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@2982

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@2982

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@2982

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@2982

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@2982

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@2982

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@2982

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@2982

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@2982

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@2982

commit: cdf5e4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant