Repository navigation
fix(frontend): fix the Docker image build and deploy security.txt - #681
Merged
Merged
Conversation
Node 25+ images no longer include Yarn, so the frontend image build has failed with "yarn: not found" since the switch to node:26-slim. Run the release from yarnPath in .yarnrc.yml instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SWRrkKuxAPsQcvYvcdPEZh
|
Visit the preview URL for this PR (updated for commit d016570): https://tormap-36f44--pr681-claude-project-threa-ek62frr3.web.app (expires Sat, 07 Nov 2026 08:15:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0c1f71965de18e60b0e686b0d0356977fec090dc |
upload-artifact leaves out hidden files by default, so the build artifact that the Firebase deploy uses had no .well-known/ folder and tormap.org served index.html for /.well-known/security.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SWRrkKuxAPsQcvYvcdPEZh
JuliusHenke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by ju · project thread
Two deployment fixes for the frontend.
Docker image build
Since the switch to
node:26-slim(8a14752), thefrontend_dockerworkflow has failed on master withyarn: not found, because Node 25+ images no longer include Yarn. The builder now runs the Yarn release that.yarnrc.ymlpins viayarnPath, which is already in the build context. No new dependency, and Renovate keeps that path up to date.security.txt on tormap.org
After #680, tormap.org sends the new headers, but
/.well-known/security.txtstill returnsindex.html.actions/upload-artifactleaves out hidden files by default, so the build artifact that the Firebase deploy uses had no.well-known/folder. The build workflow now setsinclude-hidden-files: true. The build output contains no other hidden files.Testing
/is served with the security headers from feat: add security.txt and security headers for the frontend #680 and that/.well-known/security.txtworks./.well-known/security.txton the preview URL should now return plain text.🤖 Generated with Claude Code
https://claude.ai/code/session_01SWRrkKuxAPsQcvYvcdPEZh