Repository navigation
fix(ci): launch npm portably on Windows - #1
Open
LIghtJUNction wants to merge 1 commit into
Open
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows
latestmatrix job fails intest:integrationat the host SDK dependency installation stage:The script invokes
npmdirectly throughexecFileSync. On Windows, npm is exposed through a command shim rather than a directly executablenpmbinary.Change
Run the current npm CLI with
process.execPathand thenpm_execpathsupplied by the surroundingnpm runprocess. This avoids shell-dependent command resolution and keeps the exact npm installation already selected by the workflow.The script now also fails explicitly if it is invoked outside the required npm-script context.
Validation
npm ci --ignore-scriptsnpm run build && git diff --exit-code -- distnpm run typechecknpm test— 45 passednpm run pack:checkOPENCODE_BIN=... npm run test:hostOPENCODE_BIN=... npm run test:integration— all three protocol refusal checks, expired-credential checks, and native CLI PKCE reconnect passedgit diff --checkRisk
Low. The change is limited to test dependency bootstrapping. It does not alter the plugin runtime, authentication behavior, credentials, or production package output.