Skip to content

Set the minimum generation speed when creating a provider - #132

Merged
fylorn merged 1 commit into
devfrom
feat/min-speed-create
Oct 30, 2026
Merged

fylorn merged 1 commit into
devfrom
feat/min-speed-create

Conversation

@fylorn

@fylorn fylorn commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #131: the create-provider dialog gets the same minimum-generation-speed row as the edit dialog — "Stop when generation is slower than [ ] tokens/s for [20] s". A blank speed means off. Values are checked as they are typed, and Create is disabled while either value is out of range (speed 1–1000, window 5–120).

  • The row is now a single MinSpeedRow component that both dialogs share.
  • The create request always sends min_speed_tokens_per_sec and min_speed_window_secs; POST /api/admin/providers already accepts both.
  • No new i18n keys; en/zh stay in parity.

Tests

  • Two new dialog tests: creating a provider with a minimum set, and Create disabled for an out-of-range window. The existing create test now expects the explicit default fields.
  • pnpm lint and make precommit pass.

🤖 Generated with Claude Code

The create-provider dialog gets the same row as the edit dialog: "Stop
when generation is slower than [ ] tokens/s for [20] s", checked as
typed, a blank speed for off. The row is one component shared by both
dialogs; the create request always carries both fields.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fylorn
fylorn merged commit faa1ad5 into dev Oct 30, 2026
7 checks passed
@fylorn
fylorn deleted the feat/min-speed-create branch October 30, 2026 15:17
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant