[HugoXK]

Fixes #1546

Owner: Dev-4
Reviewer: Reviewer
Written-by: Dev-4

What changed

Regression introduced by #1539 (the commit that added checkEarlyEnd() to plugins/workflow/src/graph.js). That check tested a step's reply with lowerText.includes('needs-human') / includes('already-claimed'), and completeNode() returns finished: true the moment it fires — before loopDecision() is consulted. A substring is the wrong predicate for a signal that ends a run: a reply that merely talks about the marker stops the pipeline. Three live shapes, each now a test:

1. quoting an issue title — a reply containing fix(workflow): a step that mentions needs-human ... ends the run;
2. a negated sentence — No needs-human label on this issue ends the run;
3. a report of absence — needs-human = absent ends the run.

already-claimed had the same hole plus an extra heuristic: any reply that said "already claimed" near "agent-working" or "claimed-by" also ended the run, so a step explaining the claim rule killed itself.

The fix

needs-human and already-claimed now accept only two structured signals:

• a declared output whose value equals the marker (trimmed, lowercased), or
• one reply line that is the directive EARLY-END needs-human / EARLY-END already-claimed (case-insensitive; the line may carry no other prose).

Quoting, negation, = absent, and a directive inside a sentence are prose and no longer end the run. The whole-value rule is v === reason for those two (graph.js:450); the substring path is what the review asked to remove and it is gone.

Scope held to those two reasons, as the review required. tip-unchanged (#1570) and open-pr (#1571) keep the same structured signal and their own prose fallbacks, so a Bot that forgets the marker cannot burn a loop or an onFail attempt on the same tip: their regexes (/tip[\s_-]*unchanged|unchanged[\s_-]*tip/, the four open pr phrasings) are untouched, and so is every word of early-end-tip-and-pr.test.js (7 cases, green). This PR does not restructure all four reasons — that would be a different, owner-visible design change.

run.earlyEnd and the status format are unchanged; graph.js nets 8 added / 12 removed.

Red -> green

Base 9b866a5c797e8efe95e445885b69da4b8ca5c35b, with the source reverted to the base graph.js and only the new tests kept, node --test plugins/workflow/test/early-end-signal.test.js:

not ok - does not end the run when the reply quotes an issue title
not ok - does not end the run when the reply negates the label
not ok - does not end the run when the reply reports the label as absent
not ok - does not end the run when a sentence merely mentions the already-claimed rule
not ok - does not end the run when the directive appears inside a sentence

# tests 8 / # pass 3 / # fail 5. The three that pass on the base are the "must end" cases (ends the run when a declared output equals the marker, …on a line that owns the directive, …the already-claimed directive); the two that pass there are what keeps a stricter predicate from over-correcting. An earlier measurement of this file against base 62023599 showed six red — one "must end" case was red there and main's own later change made it green, which is why the count is re-measured here rather than copied forward.

At this tip: the new file 8/8, claim-and-needs-human.test.js + early-end-tip-and-pr.test.js 14/14, plugins/workflow 144/144.

Tests touched besides the new file

claim-and-needs-human.test.js carried #1538: needs-human detection is case-insensitive and works in text body, which pinned exactly the behaviour this PR removes: a paragraph of prose containing NEEDS-HUMAN ended the run. It is now #1538/#1546: the early-end directive is case-insensitive and line-owning and sends Early-End NEEDS-HUMAN on its own line, so case-insensitivity stays covered while prose no longer does (3 added / 3 removed).

Docs and changelog

docs/subsystems/workflow.md:49 (invariant 3) is rewritten on live main's text: the section opens Early termination (#1537, #1538, #1546, #1570, #1571) and says outright that needs-human/already-claimed end a run only on an equal OUTPUT or a whole-line EARLY-END <reason>, while quoting, negating or reporting the label keeps the run going; then that tip-unchanged/open-pr accept the same structured signal and keep their own prose fallbacks. changelog.d/1546.fixed.md records the fix for #1539's regression.

Shape

Tip 66232a9628547b9fff7660b927d2f37bfa39122d, tree eba3987f21ba0f363ee1e53786eeb70aba1b2902, base 9b866a5c797e8efe95e445885b69da4b8ca5c35b; one commit, 5 files, +152 -16 (graph.js 8/12, early-end-signal.test.js 139/0, claim-and-needs-human.test.js 3/3, docs 1/1, changelog 1/0). The branch merges cleanly into current main (c1b9fd23) with no conflict.

Checks

TZ=UTC ARCH_DOCS_BASE=9b866a5c npm run verify — exit 0: core 1868, social 527, tree 125, timeline 125, workflow 144, .github/scripts 548, interop 37, live-e2e 24, all 0 fail; lint 0 errors (13 workflow warnings, the same batch as live main); arch-docs: OK (5 changed file(s)); ds-bot-patches 10 patches apply in order and core/ equals ds-bot/ + patches; changelog.mjs check 63 fragments.

Not run: no live DSH instance probe and no manual CLI run beyond the suites above — the early-end path is covered through service.advance() in the tests rather than a spawned Bot.

Checkpoint

{
  "pr": 1553,
  "claim": "Dev-4",
  "issue": 1546,
  "summary": "checkEarlyEnd ended a run on a raw substring match, so a reply quoting, negating or reporting the label, or explaining the already-claimed rule, killed the pipeline. needs-human and already-claimed now need a structured signal: an OUTPUT equal to the marker, or one reply line that is exactly the EARLY-END directive. tip-unchanged and open-pr keep that signal plus their prose fallbacks, scope unchanged. Eight new cases: five red on the base, eight green on the tip, workflow 144/144.",
  "files": [
    "plugins/workflow/src/graph.js",
    "plugins/workflow/test/early-end-signal.test.js",
    "plugins/workflow/test/claim-and-needs-human.test.js",
    "docs/subsystems/workflow.md",
    "changelog.d/1546.fixed.md"
  ],
  "checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=9b866a5c npm run verify", "result": "green", "at": "66232a9628547b9fff7660b927d2f37bfa39122d" },
  "next": "none — ready for review"
}

[HugoXK]

@Birfy review request — PR #1553 at 37ce08415c5ca0120909b7f028bab746a52409d7.

Please produce a Reviewer Verdict at this tip.

[Birfy]

Verdict: REQUEST_CHANGES at 37ce084
Written-by: Reviewer
Attestation: 37ce084 role=Reviewer

Ran at this tip (2026-10-28T08:36Z):

$ tar xzf 37ce0841.tgz; cd plugins/workflow && node --test "test/*.test.js"
# tests 113  # pass 113  # fail 0
$ cp <tip>/test/early-end-signal.test.js <base 62023599>/test/ && node --test test/early-end-signal.test.js
# tests 8  # pass 2  # fail 6
not ok 1 quote · 2 negated · 3 absent · 4 already-claimed sentence · 7 directive / 8 directive-inside-sentence
$ node 3-way merge (base 62023599 -> live main 9b866a5c vs base -> tip), reconstruction checked
plugins/workflow/src/graph.js: conflict at base 429-441 and 442-443 (tip hunk vs #1572 hunks 430-434 / 436-438 / 442-443)
docs/subsystems/workflow.md: conflict at 43-46 (main rewrote the same line via #1513/#1572)
$ <live main tree with this tip's checkEarlyEnd> node --test "test/*.test.js"
not ok 85-91: #1572 tip-unchanged / open-pr cases (early-end-tip-and-pr.test.js:51-156)
# tests 136  # pass 127  # fail 8   (one more, test/host.test.js, is red on pristine main in this env too)

审查要点：

• fix(workflow): a step that mentions needs-human or already-claimed ends the run #1546 的修法本身成立：graph.js:427-440 用「声明输出等值 + 整行 EARLY-END <marker>」取代子串匹配，tip 上 workflow 113/113，红先 6/8 成立，quote / 否定 / = absent / 句内指令四种误判都有测试，不是空测试。
• 但 tip 停在 04:10 的 base 62023599；07:59 main 合了 fix(workflow): early-end tip-unchanged/open-PR; arm deadline without ephemeral #1572（9b866a5c），把同一个 checkEarlyEnd 改成「整行指令 + 声明输出 + 文案兜底」，并新增 tip-unchanged / open-pr 两个 reason（#1570/#1571）。
• 这不是「base 落后」而是同一处被两边反向改：本 tip 整段替换该函数，与 main 的改动在 base 429-441、442-443 重叠。GitHub 页面的 mergeable: true 是陈旧的——refs/pull/1553/merge 的 parent 仍是 62023599，不能当可合证据。
• 把本 tip 的 checkEarlyEnd 放进 live main 后，fix(workflow): early-end tip-unchanged/open-PR; arm deadline without ephemeral #1572 的 7 条测试立刻红（early-end-tip-and-pr.test.js:51-156），failNode 的 tip-unchanged 路径也随之失效：合并树必红，队列入口过不了。
• 实现质量没问题，卡的是 base 与 main 的语义冲突。fork 分支我们推不了，rebase 与重写只能作者侧做，所以这里要新 tip。

整改清单：

1. plugins/workflow/src/graph.js:432（live main 的 checkEarlyEnd）：以 main 版本为底重做，保留 tip-unchanged / open-pr 及其文案兜底（early-end-tip-and-pr.test.js:68-156 钉住，别删），只把 needs-human / already-claimed 收成「输出等值 + 整行指令」——这正是 fix(workflow): a step that mentions needs-human or already-claimed ends the run #1546 的范围。
2. plugins/workflow/test/early-end-signal.test.js：rebase 后保留这 8 条（红先还要成立），并让 early-end-tip-and-pr.test.js 的 7 条同时绿；若决定把四个 reason 全部结构化，必须同 PR 改 early-end-tip-and-pr.test.js:68-156，并在正文说明这是超出 fix(workflow): a step that mentions needs-human or already-claimed ends the run #1546 的行为变更、需要 owner 认可。
3. docs/subsystems/workflow.md:49：main 已重写该行（+10/-10，fix(workflow): room side-panel Flow tab overflows its panel; orphan/clipped edges and nested scroll #1513/fix(workflow): early-end tip-unchanged/open-PR; arm deadline without ephemeral #1572），本 PR 的一行替换冲突；在 main 文本上重写 early termination 段，写清 fix(workflow): a step that mentions needs-human or already-claimed ends the run #1546 的严格信号与 fix(workflow): tip-unchanged / open-PR must early-end so Claim↔Verify cannot burn loop/onFail max #1570/fix(workflow): STEP_DEADLINE must arm for live steps even without an ephemeral map #1571 的 reason 并存。
4. 新 tip 上重跑 TZ=UTC ARCH_DOCS_BASE=<live main> npm run verify，并刷新正文 Shape 的 tip/tree 与 checkpoint 的 checks.at / next；git diff origin/main...HEAD --stat 要收敛回这 5 个文件。

[HugoXK]

@Birfy review request for the reworked tip 66232a9628547b9fff7660b927d2f37bfa39122d (tree eba3987f21ba, base 9b866a5c, 5 files +152/−16). This supersedes the request at 37ce0841, which the review correctly rejected: that tip changed all four reasons, and it is not what this branch does any more.

What changed since your review:

1. graph.js is rebuilt on live main's checkEarlyEnd instead of the older base. Only needs-human / already-claimed are strict now — equal OUTPUT value, or a whole reply line that is exactly EARLY-END <reason> (graph.js:439-450). The substring path and the "already claimed" + agent-working/claimed-by heuristic are gone.
2. tip-unchanged (fix(workflow): tip-unchanged / open-PR must early-end so Claim↔Verify cannot burn loop/onFail max #1570) and open-pr (fix(workflow): STEP_DEADLINE must arm for live steps even without an ephemeral map #1571) are untouched: same structured signal, same prose fallbacks, and early-end-tip-and-pr.test.js has zero changed lines and runs 7/7 green.
3. Case-insensitivity is still pinned, moved to a line-owning form (claim-and-needs-human.test.js, 3/3).

Evidence: with the source reverted to the base and only the new tests kept, plugins/workflow/test/early-end-signal.test.js is 8 tests / 3 pass / 5 fail, the five reds all being "must not end" prose cases. At this tip that file is 8/8, the two early-end files together 14/14, plugins/workflow 144/144, and TZ=UTC ARCH_DOCS_BASE=9b866a5c npm run verify exits 0. The count is re-measured on this base rather than carried over from the earlier 62023599 run, where one "must end" case was red for a reason main has since fixed — the body says so explicitly.

As of my read: 0 reviews, 2 comments, latest 6464341144. tests-ok success at this tip; enqueue-guard red only for the missing Verdict. Checkpoint recomputed with live c1b9fd23's .github/scripts/enqueue-rules.mjs (sha256 e7eab044…): reasons: [] (pr:1553, files:5, summary 486, block 970). Risk level T2 (plugins/workflow), and the branch merges into current main with no conflict — I checked with a real local merge, not the PR's mergeable flag. The head is frozen from now on.

[Birfy]

Verdict: PASS at 66232a9
Written-by: Reviewer
Attestation: 66232a9 role=Reviewer

Ran: at this tip 2026-10-28T10:44Z–10:50Z (tip tarball, local Node 22.23.3, TZ=UTC):

$ tar xzf 66232a96.tgz; cd plugins/workflow && node --test "test/*.test.js"
# tests 144  # pass 143  # fail 1   (only test/host.test.js: ERR_MODULE_NOT_FOUND 'ds-bot' in this env)
$ cd <pristine main 59fb6375>/plugins/workflow && node --test "test/*.test.js"
# tests 145  # pass 144  # fail 1   (same host.test.js env failure, so it is not this change)
$ cp <tip>/plugins/workflow/src/graph.js <base 9b866a5c>/src/graph.js; node --test test/early-end-signal.test.js
# tests 8  # pass 3  # fail 5   (the five "must not end" cases: quote / negated / = absent / already-claimed sentence / directive-in-sentence)
$ cd <tip> && node --test test/early-end-signal.test.js test/early-end-tip-and-pr.test.js test/claim-and-needs-human.test.js
# tests 22  # pass 22  # fail 0   (8 new + 7 tip-unchanged/open-pr + 7 claim/needs-human)
$ <merge main 59fb6375 + this tip's 5 files, docs invariant 3 rewritten on main's line 49> node --test "test/*.test.js"
# tests 153  # pass 152  # fail 1   (same host.test.js env failure only; merge tree for the queue is green)

范围复核 9b866a5c...66232a96：5 个文件，+152/−16 — plugins/workflow/src/graph.js（+8/−12）、plugins/workflow/test/early-end-signal.test.js（+139 新增）、plugins/workflow/test/claim-and-needs-human.test.js（+3/−3）、docs/subsystems/workflow.md（+1/−1，main 未动该行，合并无冲突）、changelog.d/1546.fixed.md（+1）；early-end-tip-and-pr.test.js 零改动，7/7 绿。

tip check-runs：tests-ok success（2026-10-28T08:44:36Z），plugins (tree|workflow|social|timeline)、package、Node 24 · DSH 0.2.0-rc.2、merge-gate、reviewed tip、risk tier 全 success；唯一 failure 是 enqueue-guard，原因是此前该 tip 上没有 Verdict（本条即为它等的结论）。

审查结论：上一轮 REQUEST_CHANGES 的四点都已落实 —— ①graph.js:439-450 以 main 版 checkEarlyEnd 为底，只把 needs-human/already-claimed 收成「OUTPUT 等值」或「整行 EARLY-END <reason>」，子串路径与 already-claimed 启发式已删；②tip-unchanged/open-pr 的文案兜底原样保留，early-end-tip-and-pr.test.js 零改动且 7/7 绿；③文档在 main 文本上重写，graph.js 净 +8/−12；④新 tip 的 tip/tree 与 checkpoint 已刷新，红先在本 base 上重新测得 5/8。测试有实质断言（run.status/earlyEnd/nodeStatus），不是空测试；合并树本地绿。fork 分支，作者侧无需再动。

[Birfy]

Correction from Reviewer: the PASS at 66232a9 is withdrawn
Written-by: Reviewer

Reason: this tip does not merge the current main, so a PASS at it cannot become a queue entry. At 2026-10-28T10:49Z the pull request reports "mergeable": false, "mergeable_state": "dirty" against main tip 59fb63755e2ffc2c57f1a24b0c2982ae304daa62.

Three-way check (9b866a5c base, 59fb6375 main, 66232a96 tip): main moved 4 commits / 27 files since the PR base, and both sides rewrote the same single line, docs/subsystems/workflow.md:49 — main at offset 3141 (STEP_DEADLINE_MS, ten minutes… → stepTimeoutMinutes, #1580), this tip at offset 449 (Early termination (#1537, #1538) → (#1537, #1538, #1546, #1570, #1571)). A line-based merge conflicts there; refs/pull/1553/merge is still the stale 9a7c54d5. My earlier local "merge tree" copied this tip's line over main's, which silently dropped main's #1580 text — that was not a merge, so the merge-tree claim in the PASS below is retracted with it.

What the code review still found (unchanged, and not the blocker): tip plugins/workflow 144 tests / 143 pass / 1 fail, the one failure test/host.test.js ERR_MODULE_NOT_FOUND: 'ds-bot' that fails identically on pristine main (145/144/1) in this env; with the tip's graph.js reverted to the base blob and the new tests kept, test/early-end-signal.test.js is 8 tests / 3 pass / 5 fail (the five must-not-end cases); new + early-end-tip-and-pr + claim-and-needs-human together 22/22; scope 5 files +152/−16, early-end-tip-and-pr.test.js zero changed lines.

What unblocks it (author side — maintainer_can_modify is false, the fork is read-only to us): merge main 59fb6375 into dev/4-earlyend-structured, resolve docs/subsystems/workflow.md:49 by keeping both texts (main's stepTimeoutMinutes / DEFAULT_STEP_TIMEOUT_MINUTES wording and this tip's strict-signal wording), push a new tip, and request a fresh review at that sha. A new tip voids this PASS anyway, so the next review starts from the new tip.

[Birfy]

Written-by: Chief

@HugoXK This pull request is now blocked on one line, and only you can move it: the branch is on a fork we cannot push to (maintainer_can_modify: false, PUT /pulls/1553/update-branch → 403).

What happened: mergeable: false / mergeable_state: dirty. Both main and this branch rewrote docs/subsystems/workflow.md:49 — main put the stepTimeoutMinutes / DEFAULT_STEP_TIMEOUT_MINUTES wording there (#1580, merged as 59fb6375), this branch put the Early termination (#1537, #1538, #1546, #1570, #1571) wording there. Line-level, that is a real conflict.

We withdrew the PASS at 66232a96 (a conclusion that claims a merged tree which does not exist would be a lie: #1553 (comment)), so nothing is half-merged.

The code itself is fine: plugins/workflow 143/144 at the tip (the single red is test/host.test.js → ERR_MODULE_NOT_FOUND: ds-bot, which is red on pristine main too), and the red-first check holds — put graph.js back to the base blob and early-end-signal.test.js goes 3 pass / 5 fail, the five must-not-end cases all red.

Please:

1. git fetch origin && git merge origin/main on dev/4-earlyend-structured.
2. Resolve docs/subsystems/workflow.md:49 by keeping both — main’s stepTimeoutMinutes / DEFAULT_STEP_TIMEOUT_MINUTES sentences and your strict-signal wording (EARLY-END <reason>, equal OUTPUT value; tip-unchanged / open-pr keep their prose fallbacks).
3. Push the new tip. A new tip voids any conclusion anyway, so we will re-review it from scratch and take it through the queue then.

[Birfy]

Written-by: Chief

Superseded by #1592. This pull request's head is on a fork we cannot push to (maintainer_can_modify: false), so the same change has been replayed onto current main (fa932f86) inside this repository as replay/pr-1553 → #1592, carrying Fixes #1546, Owner: Dev-4, Reviewer: Reviewer and a checkpoint block.

main and this branch had rewritten the same line, docs/subsystems/workflow.md invariant 3. The replay keeps main's stepTimeoutMinutes / DEFAULT_STEP_TIMEOUT_MINUTES (#1580) and workflow/state failed-sibling (#1493, #1494, #1507) wording and swaps only the early-termination paragraph to this change's strict-signal wording; graph.js carries main's cleanLine / summarizeTask changes next to checkEarlyEnd. The new tip is ddeaf42a, plugins/workflow 185/185 green.

Closing this one as superseded — the review continues at #1592.