Skip to content

A run started by a remote (friend's) Bot gets no connectors #1555

Closed

Description

@HugoXK

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment on this issue.

Written-by: FlyBot Lead
Claimed-by: FlyBot Lead
Claim-Id: 3b86e287b0054fb49668d01067b42cc3
Branch: dev/2-remote-caller-no-connectors
Base: 6202359
At: 2026-10-28T04:41:45Z

Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment.

Written-by: FlyBot Lead

What — run_workflow / define_workflow can be called by a Bot from another owner (a remote Bot). Such a caller has no connector switch table we can intersect with, so the run Bot started for it is not capped by the caller's switches at all.

Expected — A remote caller gets no connector: the run Bot it starts has an empty connector set, so nothing of ours is reachable through it. An in-team Bot whose own switch for a connector is on, and whose node names that connector, keeps it (unchanged).

Scope — Host layer only: core/src/host/connector-access.js, the ephemeral branch — allowed() and the shared denied() / restrict() mask. Treat "the caller is remote" exactly like "the caller switched it off": fail closed, no connector. No new capability, nothing widened.

Tests — one true-red test at the guard: a remote caller → no connector in denied() / restrict() (assert on the mask and the guard message, not on allowed() alone). One regression case in the same file: an in-team Bot with the connector on + a node whose tools name it is still allowed, so the change cannot over-refuse.

Out of scope — visibleTo on the two tools stays backlog; not part of this issue.

Activity

  1. HugoXK commented on Oct 28, 2026

    @HugoXK
    ContributorAuthor

    Claim

    Written-by: FlyBot Lead
    Claimed-by: FlyBot Lead
    Claim-Id: 3b86e287b0054fb49668d01067b42cc3
    Branch: dev/2-remote-caller-no-connectors
    Base: 6202359

  2. Birfy commented on Oct 28, 2026

    @Birfy
    Collaborator

    Written-by: Triage

    Label repair at 2026-10-28T10:50:37Z: agent-pr added — this issue's open pull request is #1558 (fork HugoXK/FlyBot), head 93c77523cc51dbbdc411172e485af2f6b555f9d4. Implementation stays on the pull request line; nothing new starts from this issue.

  3. Birfy commented on Oct 28, 2026

    @Birfy
    Collaborator

    Written-by: Chief

    The pull request for this issue (#1558) had its head on a fork we cannot push to (maintainer_can_modify=false), so the change was replayed onto current main in this repository and opened as #1590. #1558 is closed as superseded; #1590 carries the change for #1555.

  4. added a commit that references this issue on Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions