Repository navigation
issueCardForTask is dead code after #1370 removed its only consumer #1376
Description
Leftover from #1370 (merged as ed89efc4), spotted while reviewing that PR. Filing it so the finding is recorded rather than only living in review comments.
Fact. core/src/shared/issue-ref.js:69 still exports issueCardForTask(task, issues). Its only consumer was core/src/client/delivery-view.js:17 (the #1360/#1361 nesting view), and #1370 deleted that whole file. On main today the name appears in exactly three places:
core/src/shared/issue-ref.js:69— the definitionpatches/ds-bot/files/src/shared/issue-ref.js— the byte-identical patch mirrordocs/subsystems/core-host.md:56— still lists it as one of the four exports of the matcher
Code search over repo:ThinkFlowLab/FlyBot shows no call site and no test: core/test/delivery-view.test.js (deleted) held the only coverage of the nesting path it served.
Why it matters. An exported helper with no consumer and no test rots silently: nothing fails if someone changes it, and the host doc advertises an API the product no longer uses. Either delete issueCardForTask and its line in core-host.md:56 (plus the patches/ds-bot/files/ mirror), or keep it and say in the doc why the matcher still needs it — but as it stands the docs and the code disagree with the tree that shipped.
Not urgent, and not a regression: #1370 is a deliberate removal, this is the tail it left behind.
Discovered while acting as reviewer on #1363 / #1370; no code written for this.
Activity
Birfy commentedon Oct 27, 2026
Triaged on main
18d567bb(read2026-10-27T09:45Z). Both halves still stand; only the line numbers moved.Duplicate check — none.
search is:issue issueCardForTask→ this issue only;is:issue in:title "dead code"→ this issue only. Not#1392: that merged as06bed53band touchedcore/src/shared/issue-ref.jsonly in the bare-number regex and its comment (+12/−3).issueCardForTaskwas not touched by it — it drifted69 → 78because#1392added nine comment lines aboveISSUE_REF.Still true, verified at
18d567bb(identical at06bed53b):core/src/shared/issue-ref.js:78export function issueCardForTask(task, issues), plus the four private pieces only it uses:MENTION:45,mentionOf:47-52,cardMentions:56(also exported, also imported by nothing),asNumber:72.issueCardForTask→ 3 hits: the definition;patches/ds-bot/files/src/shared/issue-ref.js:78(byte-identical mirror — both blobs are48316b46);docs/subsystems/core-host.md:56. No call site, no test.cardNamesIssuestill has live consumers (core/src/host/work-dispatch.js:8re-export,core/src/host/tasks.jsassignFromDispatch), so this really is only the nesting half.core-host.md:56—#1370already rewrote that sentence, so it no longer claims the board callsissueCardForTask; it now says the hang is not drawn (Remove the delivery board (GitHub repo metrics panel) #1363). What is left is that it still lists the name as one of the matcher's exports. Fix = drop the name and the trailing clause; no new justification sentence needed.Expected behaviour after the change.
core/src/shared/issue-ref.jsexports exactlyrefOf,issueRefs,namesIssue,cardNamesIssue,issueRefPattern.issueCardForTask,cardMentions,mentionOf,MENTIONandasNumberare gone together, and nothing in the tree names any of them.Scope — four files and one fragment:
core/src/shared/issue-ref.js— delete:42-100(theMENTIONblock throughissueCardForTask); keepISSUE_REF,refOf…cardNamesIssue,issueRefPattern, and the file's header comment.patches/ds-bot/files/src/shared/issue-ref.js— regenerate withnode scripts/ds-bot-patches.mjs generate; never hand-edit. Both mirrors must carry the same blob.docs/subsystems/core-host.md:56— removeand \issueCardForTask`from the export list and the closing clause *\issueCardForTask` answers which GitHub issue card a task would hang under; that hang was the delivery board and is not drawn (Remove the delivery board (GitHub repo metrics panel) #1363)*. The rest of the row stays.core/test/no-delivery-board.test.js— this file is exactly the#1363"must not come back" guard, so the removal is pinned there: one test assertingread('src/shared/issue-ref.js')does not match/issueCardForTask|cardMentions/, and that no othersrc/**ortest/**file names them (the test already reads files by relative path).changelog.d/1376.removed.md— one line, same shape aschangelog.d/1363.removed.md.Acceptance, run at the tip:
node --test core/test/no-delivery-board.test.js core/test/issue-ref.test.js core/test/work-dispatch.test.jsgreen, andnpm testgreen.node scripts/ds-bot-patches.mjs generateleavesgit diff --statempty afterwards (mirror and*.patchin sync, no unrelated churn).git grep -n "issueCardForTask\|cardMentions" -- ':!patches/ds-bot/*.patch' | wc -l→0.Labels stay
enhancement+area:automation— not a regression:#1370was a deliberate removal and this is the tail it left.Owner:
Dev4(Lead's pick,09:44Z).Birfy commentedon Oct 27, 2026
Owner correction, per Lead
2026-10-27T09:52Z:Dev2, notDev4.Dev4takes#1388(branchdev4/1388-reap-running, in flight since09:49Z), one pull request each. Everything else in my triage comment above — line numbers78on main18d567bb, the deletion set (issueCardForTask,cardMentions,mentionOf,MENTION,asNumber), the doc line, theno-delivery-board.test.jsguard, thechangelog.d/1376.removed.mdfragment, the regenerate-the-mirror rule and the four acceptance items — stands unchanged.Birfy commentedon Oct 27, 2026
Dev2 claims this: branch
dev2/1376-issuecardfortask-dead-codefrom base5123a872, draft pull request #1417.Deleting
issueCardForTaskwithcardMentions,mentionOf,MENTIONandasNumber;cardNamesIssuestays (its callers arework-dispatch.jsandtasks.js).chore(issue-ref): drop the dead delivery-board nesting helper (#1376)