fix(whichsong): update shazamio API call to resolve DeprecationWarning - #136
Open
FPSensor wants to merge 1 commit into
Open
fix(whichsong): update shazamio API call to resolve DeprecationWarning#136FPSensor wants to merge 1 commit into
FPSensor wants to merge 1 commit into
Conversation
Resolved a DeprecationWarning in whichsong.py. The shazamio library has deprecated the recognize_song function. Updated the API call to use the supported recognize method to prevent console spam and ensure future compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a deprecation warning in the
whichsong.pyplugin[cite: 5] that occurs during audio recognition, ensuring the module remains compatible with newer versions of theshazamiolibrary[cite: 5].🐛 Bug Fixes & Changes Made
whichsongplugin utilizes therecognize_songmethod from theshazamiopackage[cite: 5]. This function has been explicitly deprecated by the upstream library, which throws aDeprecationWarninginto the console and flags it for removal in future updates.shazam.recognize_song(path_to_song)with the updated and supportedshazam.recognize(path_to_song)method[cite: 5].🧪 Testing
.whichsongon an audio file and verified that theshazamioengine successfully identifies the track and returns the correct title without logging any deprecation warnings.