Skip to content

Fixes for deprecated pointer devices - #62

Merged
KenVanHoeylandt merged 3 commits into
mainfrom
fixes-for-pointer-devices
Oct 24, 2026
Merged

KenVanHoeylandt merged 3 commits into
mainfrom
fixes-for-pointer-devices

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Replaced logic with touch and mouse devices. Removed support for deprecated pointer device.

Summary by CodeRabbit

  • New Features

    • Doom, Graphics Demo, and Mystify Demo can now respond to either touch input or the primary mouse button.
    • The demos can start when either a touch device or a mouse is available.
  • Bug Fixes

    • SDK platform checks now ignore installed platform directories that are no longer listed as available.
    • Requests to install unavailable platforms now fail with an error before installation proceeds.

Replaced logic with touch and mouse devices. Removed support for
deprecated pointer device.
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 45b1acda-bc66-462f-b0dd-2e25a36d6767
Commits

Reviewing files that changed from the base of the PR and between 42f1dcb and 9ce3e95.

Files selected for processing: 5
  • Apps/Doom/main/Source/Application.cpp
  • Apps/Doom/main/Source/main.cpp
  • Apps/Doom/manifest.properties
  • Apps/GraphicsDemo/manifest.properties
  • Apps/MystifyDemo/manifest.properties
Walkthrough

Doom, GraphicsDemo, and MystifyDemo now look up touch and mouse devices separately. They accept mouse button 0 as touched input when touch does not report a touched point. The SDK tool updates its version and changes how it checks installed and requested platforms against the SDK index.

Priority: Pending latest changes

Merge Risk: Low · up to 42f1d

An obsolete installed platform can still be used, while Doom can retain device references or miss a touch-stop request after a read error. These bounded issues merit fixes or explicit acceptance before merging.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 35.71% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 10 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: replacing deprecated pointer-device support with touch and mouse device logic.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6056c1c1-e2df-48ec-bc72-8be63974d8b4
Commits

Reviewing files that changed from the base of the PR and between 7383cca and 42f1dcb.

Files selected for processing: 10
  • Apps/Doom/main/Source/Application.cpp
  • Apps/Doom/main/Source/Application.h
  • Apps/Doom/main/Source/main.cpp
  • Apps/GraphicsDemo/main/Include/drivers/TouchDriver.h
  • Apps/GraphicsDemo/main/Source/Application.cpp
  • Apps/GraphicsDemo/main/Source/Main.cpp
  • Apps/MystifyDemo/main/Include/drivers/TouchDriver.h
  • Apps/MystifyDemo/main/Source/Application.cpp
  • Apps/MystifyDemo/main/Source/Main.cpp
  • tt.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread Apps/Doom/main/Source/Application.cpp Outdated
Comment thread Apps/Doom/main/Source/main.cpp
Comment thread tt.py
@KenVanHoeylandt
KenVanHoeylandt merged commit 76c3554 into main Oct 24, 2026
3 of 7 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the fixes-for-pointer-devices branch October 24, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant