Skip to content

Fix GPIO app for mono and compact themes #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KenVanHoeylandt merged 1 commit into from
Oct 23, 2026
Merged

Fix GPIO app for mono and compact themes #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Apps/GPIO/main/Source/Gpio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ static void updatePinWidgets(Context* ctx) {
// The user data stores the state, so we can avoid unnecessary updates
if (reinterpret_cast<void*>(level) != label_user_data) {
lv_obj_set_user_data(label, reinterpret_cast<void*>(level));
if (level == 0) {
lv_obj_set_style_bg_color(label, lv_color_make(20, 20, 20), LV_STATE_DEFAULT);
} else {
lv_obj_set_style_bg_color(label, lv_color_make(0, 200, 0), LV_STATE_DEFAULT);
}
lv_obj_set_style_bg_opa(label, level == 0 ? LV_OPA_TRANSP : LV_OPA_COVER, LV_STATE_DEFAULT);
}
}
lvgl_unlock();
Expand Down Expand Up @@ -102,7 +98,8 @@ void gpioCreateWidgets(lv_obj_t* parent, void* userData) {

auto block_size = lvgl_get_text_font_height(FONT_SIZE_DEFAULT);
auto lvgl_density = lvgl_get_ui_density();
const int32_t square_spacing = (lvgl_density == LVGL_UI_DENSITY_COMPACT) ? 0 : 4;
const int32_t square_spacing = (lvgl_density == LVGL_UI_DENSITY_COMPACT) ? 1 : 4;
const int32_t border_width = (lvgl_density == LVGL_UI_DENSITY_COMPACT) ? 1 : LV_DPX(1);
int32_t x_spacing = block_size + square_spacing;
uint8_t column = 0;
const uint8_t column_limit = is_landscape_display ? 10 : 5;
Expand Down Expand Up @@ -139,10 +136,13 @@ void gpioCreateWidgets(lv_obj_t* parent, void* userData) {
lv_obj_set_size(status_square, block_size, block_size);
lv_obj_set_style_pad_all(status_square, 0, LV_STATE_DEFAULT);
lv_obj_set_style_margin_all(status_square, 0, LV_STATE_DEFAULT);
lv_obj_set_style_border_width(status_square, 0, LV_STATE_DEFAULT);
// Low is an outline, high is filled
const lv_color_t secondary = lv_theme_get_color_secondary(status_square);
lv_obj_set_style_border_width(status_square, border_width, LV_STATE_DEFAULT);
lv_obj_set_style_border_color(status_square, secondary, LV_STATE_DEFAULT);
lv_obj_set_style_radius(status_square, 0, LV_STATE_DEFAULT);
lv_obj_set_style_bg_color(status_square, lv_color_make(20, 20, 20), LV_STATE_DEFAULT);
lv_obj_set_style_bg_opa(status_square, LV_OPA_COVER, LV_STATE_DEFAULT);
lv_obj_set_style_bg_color(status_square, secondary, LV_STATE_DEFAULT);
lv_obj_set_style_bg_opa(status_square, LV_OPA_TRANSP, LV_STATE_DEFAULT);
ctx->pinWidgets[i] = status_square;
ctx->pinStates[i] = false;

Expand Down
4 changes: 2 additions & 2 deletions Apps/GPIO/manifest.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ manifest.version=0.3
target.sdk=0.8.0-dev
target.platforms=esp32,esp32s3,esp32c6,esp32p4
id=tactility.gpio
version.name=0.19.0
version.code=19
version.name=0.20.0
version.code=20
name=GPIO
description=Shows the live state of all GPIO pins
app.0.id=tactility.gpio
Expand Down
Loading