Repository navigation
feat(harbor): rewrite the About tab and fix header clipping - #273
Merged
Merged
Conversation
The About tab now leads with the node's version and links to the docs, changelog, issues and source, covers machines with several cards, and drops planned features that shipped or changed. Its sections are cards in two columns on a wide screen, with the same section rail as the other tabs. The header no longer clips the ADVANCED switch or cuts its tagline off, and a phone alert wraps instead of ending in an ellipsis. A section link such as #sec-library opened the card tab on a reload. It now opens the tab that holds the section.
The scroll ran before the first status rendered its alerts and panels, so a linked section landed under the header or far below it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The harbor's About tab still described the one-card harbor of v0.3. It was one narrow column of 1,640 words with no way to jump between sections. The header also clipped at common laptop widths, and on a phone an alert lost its message to an ellipsis. This PR rewrites About for v0.4 and fixes the layout faults I measured.
About tab
/gui/page, and the rest of the list no longer matched the roadmap. The last section says what the harbor does not do yet, gives the terminal commands, and links the roadmap.Header and alerts
Measured with Playwright on the demo fixture, by counting header and alert elements whose text overflows their box:
Fix: section links on reload
The section rails write the hash (
#sec-library). On a reload,wireTabstreated an unknown hash as the card tab, so a shared link to any engines-tab section opened the wrong tab. It now opens the tab that holds the section and scrolls to it after the first status renders, because the alerts and panels that status adds move the section down. Tab hashes and#ticket=links work as before.Proof
#sec-library, a linked section landing below the sticky header,#about-kpis,#engines,#about, an unknown hash and#ticket=, key 3, a rail jump and the reload after it, the version line, the rail's 13 links, and no page errors. All 28 pass. Againstnext, the#sec-librarycheck fails.go build,gofmt,go vet, the Windows build and vet,golangci-lint(0 issues) andgo test ./...all pass.[Unreleased]anddocs/harbor.mdare updated.The page is still read only. No API or Go code changes.