Repository navigation
Merge main into next: v0.4.0 and the CI fixes from #269 - #270
Merged
Merged
Conversation
Release v0.4.0
When berthd went away mid-run, the listener wrote an unprotected-run record and then waited to re-attach. If the engine exited in that wait, Run returned before the listener removed the record. A test that removed its temp dir right after Run returned failed with "directory not empty", which turned CI red on main after the v0.4.0 merge. Run now hangs up the first connection when the engine exits and waits for the listener to finish before it returns.
The test pinned its requests to 2026-10-28 21:35 MDT. The watcher keeps 24 hours of requests, so from 2026-10-30 03:35 UTC it dropped both rows and the test failed on every branch. The fixture now sits an hour before the test runs, with the same zone and microseconds.
fix: turn CI on main green (unprotected record race, stale Strata fixture)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings
nextup tomain. It adds the v0.4.0 release commit and the two CI fixes from #269.nextcurrently failsTestStrataRequestsReachTheLeaderboard, because its fixture fell outside the engine watcher's 24h request window. Every PR based onnextfails CI until this lands, #221 included.nextis an ancestor ofmain, so the merge has no conflicts. The v0.4.0 notes sit under## [v0.4.0], and## [Unreleased]is empty.