Repository navigation
perf(discovery): skip composer.json probes for manifest-cached packages - #27
Merged
Merged
Conversation
On a manifest cache hit every package's composer.json was still stat()ed before its cached metadata was used, although the manifest fingerprint check had just validated the same file. Probe the filesystem only for files the manifest does not know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Review finding K-P3: bundle discovery runs on every request. The manifest cache already saves
getInstalledPackages()and thecomposer.jsonparsing, butcomposerBundle()andrequirementsActive()still calledis_file()on every packagecomposer.jsonbefore using the cached metadata.KernelPackageManifestCache::read()had just validated exactly those files through their recorded fingerprints (inputs).Change
BundleDiscovery::knownComposerFile()probes the filesystem only for files the manifest does not know. Everything else in discovery is unchanged: the active-package resolution still runs (it depends onactive_plugins), bundle instantiation and theRequiredBundlereflection stay.The remaining per-package cost on a warm hit is one
getInstallPath()lookup from Composer's in-memory data, the activity check and the bundle constructor; persisting the sorted bundle list itself was not worth a new manifest format.Verification
Bundle, discovery and cache suites pass;
composer csandcomposer static-analysispass in a PHP 8.5.12 container.