Repository navigation
fix(admin): carry package notices in a user transient instead of the URL - #25
Merged
Merged
Conversation
The package manager rendered kernel-package-message from the query string as an admin notice. The text was escaped, but a crafted link could still show an administrator arbitrary notice text. Redirects now keep only the notice code in the URL and stash the message in a short-lived per-user transient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Review finding K-S1 (low):
PackageManagerPagereadkernel-package-messagefrom$_GETand rendered it (escaped) as an admin notice. A crafted link could show an administrator arbitrary text as a success or error message.Change
redirect()keeps only the notice code (kernel-package-notice) in the URL and stores the message in a per-user transient (kernel_package_notice_<user id>, 60 seconds).render()takes and deletes that transient; the query string no longer carries free text.Verification
PackageManagerPageTestcovers stash/take semantics, one-shot consumption and that akernel-package-messagequery argument is ignored.composer csandcomposer static-analysispass in a PHP 8.5.12 container.