Repository navigation
Build the dispatch title list on first use - #1135
Open
rajeswaripedaballi wants to merge 2 commits into
Open
rajeswaripedaballi wants to merge 2 commits into
rajeswaripedaballi wants to merge 2 commits into
Conversation
rajeswaripedaballi
requested review from
BryceStevenWilley and
nonprofittechy
November 4, 2026 19:31
Member
|
Updated this PR in commit 38bac6c to use the public
Reviewed with Claude via Validation: all 33 targeted session and dispatch-cache tests passed; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the My interviews page shows the long file path of an interview, like
docassemble.Package:data/questions/form.yml, instead of its title. The titles come from a list that sessions.py builds as soon as the file is loaded. Because the interview list endpoint is marked # pre-load, that now happens while the server is still starting up, before every/any package has loaded. So an interview that needs something from another package can fail to load right then, and its file name gets saved as the title and just stays that way.Now the list is built the first time a title is needed, once the server is fully up. If an interview still fails, it gets tried again after a minute and the reason is logged. And if a title is just the file name, it gets skipped and the page uses its normal fallback name.
I tested it on my local and the titles show up right with nothing failing. The new tests are in
test_sessions_dispatch.py.