Skip to content

Feature Quantization [4/5]: Read updated TFRecords - #736

Merged
jchmura-sc merged 37 commits into
mainfrom
jchmura/feature_quant_read_tfrecords
Aug 12, 2026
Merged

Feature Quantization [4/5]: Read updated TFRecords#736
jchmura-sc merged 37 commits into
mainfrom
jchmura/feature_quant_read_tfrecords

Conversation

@jchmura-sc

@jchmura-sc jchmura-sc commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Purpose
The purpose of this PR is to make the read-side changes for feature quantization:

  • graph metadata translator reads feature quantization proto and constructs FeatureQuantizationMetadata
  • tfrecord data build reads quantized node feature tfrecord raw bytes and converts back to uint8

Context

Updated Changelog.md? NO

Ready for code review?: NO

@jchmura-sc jchmura-sc self-assigned this Aug 3, 2026
This was referenced Aug 3, 2026
Merged
Merged
Merged
@jchmura-sc
jchmura-sc changed the base branch from main to jchmura/feature_quant_preprocessor August 3, 2026 23:24
@jchmura-sc jchmura-sc changed the title Feature Quantization [3/5]: Read updated TFRecords Feature Quantization [4/5]: Read updated TFRecords Aug 4, 2026
@jchmura-sc jchmura-sc mentioned this pull request Aug 4, 2026
Open
@jchmura-sc
jchmura-sc marked this pull request as ready for review August 10, 2026 17:18
kmontemayor2-sc
kmontemayor2-sc approved these changes Aug 10, 2026
View reviewed changes

@kmontemayor2-sc kmontemayor2-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jacob!

Comment thread gigl/distributed/utils/serialized_graph_metadata_translator.py Outdated
Comment thread gigl/distributed/utils/serialized_graph_metadata_translator.py Outdated
Comment thread gigl/distributed/utils/serialized_graph_metadata_translator.py Outdated
Base automatically changed from jchmura/feature_quant_preprocessor to main August 11, 2026 02:11
mkolodner-sc
mkolodner-sc approved these changes Aug 11, 2026
View reviewed changes

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jacob! Generally LGTM with some small comments :)

Comment thread gigl/common/data/dataloaders.py
Comment thread gigl/distributed/utils/serialized_graph_metadata_translator.py
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 11, 2026
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 11, 2026
@jchmura-sc
jchmura-sc added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit f31d8f9 Aug 12, 2026
7 checks passed
@jchmura-sc
jchmura-sc deleted the jchmura/feature_quant_read_tfrecords branch August 12, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkolodner-sc mkolodner-sc mkolodner-sc approved these changes
@kmontemayor2-sc kmontemayor2-sc kmontemayor2-sc approved these changes
@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner
@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner
@yliu2-sc yliu2-sc Awaiting requested review from yliu2-sc yliu2-sc is a code owner
@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner
@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

@jchmura-sc jchmura-sc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jchmura-sc @mkolodner-sc @kmontemayor2-sc