Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet row pc1710-wire247-per-nick-intro-rate-limit.
#247 item 3 only: enforce the existing five-intros-per-nick-per-five-minutes limit with a hard 10,000-nick tracking cap. Reclaim expired buckets; return 429 for new nicks when all buckets remain active. Existing buckets retain their limits. Only claimed handles can allocate buckets. Global governor and other issue items remain unchanged.
Proof:
nice -n 15 cargo test -j 4 intro_rate_limit 2>&1 | grep -qE 'test result: ok\. [1-9]'(passed). Two hermetic handler tests cover sixth-request 429, another nick succeeding, window reset, bounded tracking and expired-bucket recovery, with actual isolated event persistence.Model: gpt-6.1-sol, needs cross-family rule-25 review.
Build-loop read-only Claude review reported no blockers or major defects; its minor question about arbitrary nick allocation is resolved by the existing claimed-handle lookup before tracking.