Skip to content

SlanchaAI/wire#247: bound intro buckets; Model: gpt-6.1-sol, needs cross-family rule-25 review - #393

Draft
dotfyles wants to merge 1 commit into
mainfrom
work/pc1710-wire247-per-nick-intro-rate-limit
Draft

dotfyles wants to merge 1 commit into
mainfrom
work/pc1710-wire247-per-nick-intro-rate-limit

Conversation

@dotfyles

Copy link
Copy Markdown
Contributor

Fleet row pc1710-wire247-per-nick-intro-rate-limit.

#247 item 3 only: enforce the existing five-intros-per-nick-per-five-minutes limit with a hard 10,000-nick tracking cap. Reclaim expired buckets; return 429 for new nicks when all buckets remain active. Existing buckets retain their limits. Only claimed handles can allocate buckets. Global governor and other issue items remain unchanged.

Proof: nice -n 15 cargo test -j 4 intro_rate_limit 2>&1 | grep -qE 'test result: ok\. [1-9]' (passed). Two hermetic handler tests cover sixth-request 429, another nick succeeding, window reset, bounded tracking and expired-bucket recovery, with actual isolated event persistence.

Model: gpt-6.1-sol, needs cross-family rule-25 review.

Build-loop read-only Claude review reported no blockers or major defects; its minor question about arbitrary nick allocation is resolved by the existing claimed-handle lookup before tracking.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant