Repository navigation
Fix translations - #71
Merged
Merged
Conversation
There were quite a few issues with the translations: * One string was in German instead of English. * Several translations included `\n` which is for formatting, not to be translated. * Some strings will never need to be translated, like `0 dB`. * Some translations weren't actually used. * Some translations were missing. * One translation contained a misplaced word. Documented this user-visible change in the changelog. It's not classified as a fix because text from JUCE itself might still not be translated. Regardless, the situation is better now than before.
The bash script checks two important parts of the translation files:
1. Is any text used in the code but not translated yet.
2. Is any translation not used in the code.
Those two aren't symmetrical. The second includes JUCE code but the
first doesn't since not all text from JUCE needs to be translated.
Extracting the uses of `TRANS("...")` from the code isn't
straight-forward because the strings can span multiple lines and there
can be parenthesis in the string. That's why multi-line strings are
first combined into a single line with `sed` so `grep` can then extract
the translation string.
ServiusHack
force-pushed
the
fix_translations
branch
from
October 21, 2026 18:55
2c2332a to
23e31e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed quite a few issues with the translations.
Documented this user-visible change in the changelog. It's not
classified as a fix because text from JUCE itself might still not be
translated. Regardless, the situation is better now than before.
And finally added a bash script to check translations in the CI:
Those two aren't symmetrical. The second includes JUCE code but the first
doesn't since not all text from JUCE needs to be translated.
Extracting the uses of
TRANS("...")from the code isn'tstraight-forward because the strings can span multiple lines and there
can be parenthesis in the string. That's why multi-line strings are
first combined into a single line with
sedsogrepcan then extractthe translation string.