Agent test: count utilities as mock targets - #1412
Open
yuyixg wants to merge 1 commit into
Open
Conversation
GET /agent-test/mock-targets enumerated Functions, SecondaryFunctions and McpTools only, so an agent whose whole toolset comes from utilities -- Lessen Work Order Summary, Property Summary -- reported no callable functions at all. Utilities are expanded into SecondaryFunctions by BasicAgentHook.OnAgentUtilityLoaded at conversation time, and IAgentService.GetAgent, which is what every caller here holds, is a plain repository read that never runs that hook. Cost of the gap: a case authored against such an agent blocks its own tools on the first run, and the case editor's tool picker has nothing to offer. The filter mirrors the hook -- a disabled utility is off, only a `util-` prefixed name is ever loaded as a function, and the real FunctionDef is read off UtilityAssistant rather than the agent's own declaration. VisibilityExpression is deliberately not mirrored: it needs the conversation's render data and cannot be evaluated against a stored agent, so a conditionally-visible utility is offered and may turn out not to load. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /agent-test/mock-targets enumerated Functions, SecondaryFunctions and McpTools only, so an agent whose whole toolset comes from utilities -- Lessen Work Order Summary, Property Summary -- reported no callable functions at all. Utilities are expanded into SecondaryFunctions by BasicAgentHook.OnAgentUtilityLoaded at conversation time, and IAgentService.GetAgent, which is what every caller here holds, is a plain repository read that never runs that hook.
Cost of the gap: a case authored against such an agent blocks its own tools on the first run, and the case editor's tool picker has nothing to offer.
The filter mirrors the hook -- a disabled utility is off, only a
util-prefixed name is ever loaded as a function, and the real FunctionDef is read off UtilityAssistant rather than the agent's own declaration. VisibilityExpression is deliberately not mirrored: it needs the conversation's render data and cannot be evaluated against a stored agent, so a conditionally-visible utility is offered and may turn out not to load.