-
Notifications
You must be signed in to change notification settings - Fork 0
feat: use c++ #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wispl
wants to merge
1
commit into
main
Choose a base branch
from
cpp-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| target_include_directories(common_drivers PUBLIC | ||
| "." | ||
| "sensors" | ||
| "protocols" | ||
| "flash" | ||
| ) |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #ifndef FLASH_H | ||
| #define FLASH_H | ||
|
|
||
| #include "lfs.h" | ||
|
|
||
| #include <stdint.h> | ||
|
|
||
| namespace Platform { | ||
| class Flash { | ||
| protected: | ||
| bool is_ready = false; | ||
| struct lfs_config config; | ||
| lfs_t lfs; | ||
|
|
||
| public: | ||
| virtual ~Flash() = default; | ||
| virtual bool init() = 0; | ||
| uint32_t mount(); | ||
| uint32_t unmount(); | ||
| uint32_t bootcount(bool update); | ||
| uint32_t open(lfs_file_t* file, const char* filename); | ||
| uint32_t close(lfs_file_t* file); | ||
| bool append(lfs_file_t* file, const uint8_t* bytes, size_t size); | ||
| bool ready() const { return is_ready; }; | ||
| }; | ||
| } // namespace Platform | ||
|
|
||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #ifndef HAL_H | ||
| #define HAL_H | ||
|
|
||
| #ifndef TEST | ||
| #ifdef USE_STM32_H7XX | ||
| #include "stm32h7xx_hal.h" | ||
| #elif USE_STM32_L4XX | ||
| #include "stm32l4xx_hal.h" | ||
| #else | ||
| #include "stm32f4xx_hal.h" | ||
| #endif | ||
| #else | ||
| #define HAL_Delay(...) (0) | ||
| #endif | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| #ifndef PROTOCOLS_I2C_H | ||
| #define PROTOCOLS_I2C_H | ||
|
|
||
| #include "protocol.h" | ||
|
|
||
| /// I2C tends to be register and address heavy. This really isn't really used | ||
| /// for command based sensors so the cmd buffer tends to just be the address | ||
| /// of the register to read from instead. | ||
| /// | ||
| /// The AddressSize gets directly converted to I2C's equivalent. Note that | ||
| /// unlike qspi, I2C does not support addresses greater than two bytes. | ||
| /// We use the `mem` equivalents of I2C because "most" sensors seem to | ||
| /// to prefer the pattern of specifying an address to target, followed | ||
| /// by a write or read. The `mem` I2C functions do this in one step instead | ||
| /// of two. This contrasts with SPI where we are forced to do it in two. | ||
| namespace Platform { | ||
| class I2C final : public Protocol { | ||
| private: | ||
| I2C_HandleTypeDef* handle; | ||
| const uint32_t address; | ||
|
|
||
| public: | ||
| I2C(I2C_HandleTypeDef* handle_, uin32_t address_) | ||
| : Protocol{ProtocolType::I2C}, handle{handle_}, address{address_} {} | ||
| bool read(ConstSpan cmd, Span buffer, AddressSize size) override; | ||
| bool write(ConstSpan cmd, ConstSpan buffer, AddressSize size) override; | ||
| }; | ||
| } // namespace Platform | ||
|
|
||
| #endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add a quick brief as to what these functions do.