Repository navigation
feat(api): implement thread message event listener callbacks - #1408
Open
swarnendusahu10-dotcom wants to merge 1 commit into
Open
swarnendusahu10-dotcom wants to merge 1 commit into
swarnendusahu10-dotcom wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1350
Implements the thread message event listener system in
EmbeddedChatApi.ts, fulfilling the long-standingTODOat line 239 which marked this as pending after thread UI implementation.Problem
When a user sends a reply inside an open thread, the message arrives over the DDP
room-messagesstream carrying atmid(thread message ID) field pointing to its parent. Previously, no code dispatched these messages to thread-specific listeners — theonThreadMessageCallbacksarray was declared but never populated or fired. As a result, the thread panel could not receive real-time updates and users had to manually refresh to see new replies.Changes Made
File modified:
packages/api/src/EmbeddedChatApi.ts(1 file, 27 lines added, 1 deleted)onThreadMessageCallbacksproperty (typed identically toonMessageCallbacks).[]in the constructor.room-messagesDDP stream handler: when a normalized message has a truthytmid, all registered thread listeners are called.tmidguard added to thenotify-user/messagestream (covers action-block messages sent inside threads).addThreadMessageListener()andremoveThreadMessageListener()following the exact dedup/filter pattern used by every other listener type in this class.Verification
packages/apisucceeds with no TypeScript errors.packages/reactbuild also succeeds with no warnings attributable to this change.