Repository navigation
CI updates and ICG WA - #39
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The reusable workflow’s environment-based MSVC selection remains unverified, and the GPU compiler workaround needs internal CI validation.
No open issues 🎉
What changed in this PR
This PR updates OpenVKL’s Windows CI toolchains and adds a GPU sampling workaround for the IGC-17746 compiler miscompilation.
Changes:
- Adds Visual Studio 2026 to Windows CI and consolidates build/test jobs into matrices.
- Updates DPC++ versions and centralizes GPU jobs’ MSVC selection in dependency environment files.
- Forces inlining for unstructured sampling helpers and passes sampling positions by const reference.
| File | Description |
|---|---|
openvkl/devices/gpu/compute/vklComputeUnstructured.h |
Adds forced inlining and const-reference parameters for the compiler workaround. |
openvkl/devices/gpu/compute/vklComputeParticle.h |
Passes sampling positions by const reference. |
.github/workflows/internal.release.yml |
Pins CPU jobs to MSVC 2022 and moves GPU selection to environment files. |
.github/workflows/internal.nightly.windows.yml |
Explicitly selects MSVC 2022 for debug builds. |
.github/workflows/internal.ci.windows.yml |
Introduces compiler matrices with Visual Studio 2026 coverage. |
.github/workflows/internal.ci.windows.gpu.yml |
Removes explicit MSVC inputs in favor of dependency environment settings. |
.github/workflows/internal.ci.windows.gpu.icx.yml |
Moves ICX jobs’ MSVC selection to dependency environment settings. |
.github/deps/dpcpp-windows-icx.env |
Updates Intel DPC++ to 2026.1 and specifies MSVC 2022. |
.github/deps/dpcpp-sycl-nightly.env |
Updates Intel LLVM to v7.1.0 and specifies MSVC 2022. |
Review effort: Balanced
johguenther
force-pushed
the
guj/fixes
branch
from
October 26, 2026 08:26
4cc7d90 to
9350761
Compare
- add `msvc-version` to jobs which need `cmake` - GPU tests run on Ubuntu 24.04 - bump GH action versions - add MSVC 2026 - bump dpcpp to v7.2 (benchmark needs WA for llvm-project#234701) - bump icx Windows to 2026.1
johguenther
force-pushed
the
guj/fixes
branch
from
October 26, 2026 10:52
9350761 to
5956014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.