Skip to content

chore: make the description pass the reunite starter rules - #28

Merged
vadyvas merged 7 commits into
mainfrom
feat/cafe-starter-readiness
Oct 19, 2026
Merged

vadyvas merged 7 commits into
mainfrom
feat/cafe-starter-readiness

Conversation

@vadyvas

@vadyvas vadyvas commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Prepares the Cafe description to be the API of the Reunite project starter.

  • redocly.yaml runs the starter rules. The sentence-case regex allows acronyms such as OAuth2.
  • Every scalar schema property has examples, taken from the server seed data.
  • Every error response has an example with the real server message.

The starter template must use the same regex. With the current one, 5 summaries with OAuth2 or (RFC 7591 names) fail.

@vadyvas
vadyvas force-pushed the feat/cafe-starter-readiness branch from 6ead2f1 to 7d5d085 Compare October 14, 2026 15:00
@vadyvas
vadyvas changed the base branch from fix/redocly-lint-ref-siblings to main October 14, 2026 15:00

@redocly redocly Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cafe

AI Review: 🟢 Completed

Redocly Agent has reviewed your changes and found 8 potential issue(s).

Note

Low Risk

Updates OpenAPI documentation examples and Redocly configuration only. There are no runtime code modifications, zero operational impact on the service, and the blast radius is strictly confined to API documentation and lint validation.

Overview

Aligns the Cafe API definition with the Reunite starter lint rules and improves response documentation:

  • Updates redocly.yaml with root-level rules enforcing tag definitions, example validity, and sentence-cased operation and example summaries (permitting acronyms like OAuth2).
  • Adds realistic payload examples with server error messages across shared error response components (BadRequest, Conflict, Forbidden, NotFound, Unauthorized, InternalServerError, and OAuth2 responses).
  • Updates date example summaries in openapi/paths/revenue.yaml to conform to the sentence-case rules.

Changed pages

⚙️ Configuration or theme changed

Open preview

@vadyvas
vadyvas marked this pull request as ready for review October 15, 2026 09:26
@vadyvas
vadyvas requested a review from a team October 15, 2026 09:26
Comment thread openapi/components/responses/BadRequest.yaml
@vadyvas
vadyvas force-pushed the feat/cafe-starter-readiness branch from bebeea7 to 7a4ff4e Compare October 15, 2026 11:13
Comment thread openapi/components/responses/Conflict.yaml
Comment thread openapi/paths/revenue.yaml
Comment thread openapi/components/responses/OAuth2Unauthorized.yaml
Comment thread openapi/components/responses/MenuItemNotFound.yaml Outdated
Comment thread openapi/components/responses/InternalServerError.yaml
@vadyvas vadyvas self-assigned this Oct 15, 2026
@vadyvas vadyvas changed the title feat(openapi): make the description pass the reunite starter rules feat: make the description pass the reunite starter rules Oct 16, 2026
@vadyvas vadyvas changed the title feat: make the description pass the reunite starter rules chore: make the description pass the reunite starter rules Oct 16, 2026
schema:
type: string
content:
application/json:

@tatomyr tatomyr Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same as OAuth2Unauthorized.yaml but different example, which makes the duplication unnecessary.

@vadyvas
vadyvas merged commit d7e1862 into main Oct 19, 2026
5 of 7 checks passed
@vadyvas
vadyvas deleted the feat/cafe-starter-readiness branch October 19, 2026 15:06
examples:
NotFound:
summary: No resource at this path
dataValue:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: Medium

In OpenAPI 3.x, an Example Object uses the "value" property to hold the example data, not "dataValue". Please change "dataValue" to "value". Affected examples: NotFound, MenuItemNotFound, OrderNotFound.

error_description: Invalid client credentials
InvalidToken:
summary: Wrong registration access token
dataValue:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: Medium

Please also change "dataValue" to "value" in the InvalidToken example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants