Repository navigation
chore: make the description pass the reunite starter rules - #28
Merged
Merged
Conversation
vadyvas
force-pushed
the
feat/cafe-starter-readiness
branch
from
October 14, 2026 15:00
6ead2f1 to
7d5d085
Compare
There was a problem hiding this comment.
AI Review: 🟢 Completed
Redocly Agent has reviewed your changes and found 8 potential issue(s).
Note
Low Risk
Updates OpenAPI documentation examples and Redocly configuration only. There are no runtime code modifications, zero operational impact on the service, and the blast radius is strictly confined to API documentation and lint validation.
Overview
Aligns the Cafe API definition with the Reunite starter lint rules and improves response documentation:
- Updates
redocly.yamlwith root-level rules enforcing tag definitions, example validity, and sentence-cased operation and example summaries (permitting acronyms likeOAuth2). - Adds realistic payload examples with server error messages across shared error response components (
BadRequest,Conflict,Forbidden,NotFound,Unauthorized,InternalServerError, and OAuth2 responses). - Updates date example summaries in
openapi/paths/revenue.yamlto conform to the sentence-case rules.
Changed pages
⚙️ Configuration or theme changed
vadyvas
marked this pull request as ready for review
October 15, 2026 09:26
vadyvas
force-pushed
the
feat/cafe-starter-readiness
branch
from
October 15, 2026 11:13
bebeea7 to
7a4ff4e
Compare
tatomyr
reviewed
Oct 19, 2026
| schema: | ||
| type: string | ||
| content: | ||
| application/json: |
Collaborator
There was a problem hiding this comment.
Looks the same as OAuth2Unauthorized.yaml but different example, which makes the duplication unnecessary.
tatomyr
approved these changes
Oct 19, 2026
| examples: | ||
| NotFound: | ||
| summary: No resource at this path | ||
| dataValue: |
| error_description: Invalid client credentials | ||
| InvalidToken: | ||
| summary: Wrong registration access token | ||
| dataValue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the Cafe description to be the API of the Reunite project starter.
redocly.yamlruns the starter rules. The sentence-case regex allows acronyms such asOAuth2.examples, taken from the server seed data.The starter template must use the same regex. With the current one, 5 summaries with
OAuth2or(RFC 7591 names)fail.