Skip to content

Allow type override in := when i is an ordering call - #7879

Open
venom1204 wants to merge 1 commit into
masterfrom
subset
Open

Allow type override in := when i is an ordering call#7879
venom1204 wants to merge 1 commit into
masterfrom
subset

Conversation

@venom1204

Copy link
Copy Markdown
Contributor

closes #2925

Identifies order() or forder() in i as a full-column permutation and permits a column type change (plonk) during assignment. Previously, any non-missing i was treated as a subset update, which strictly forbade type overrides.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (25c9dde) to head (21caf0d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7879   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17305    17316   +11     
=======================================
+ Hits        17135    17146   +11     
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
  • HEAD=subset much slower for transform improved in #5493
    Comparison Plot

Generated via commit 21caf0d

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 33 seconds
Installing different package versions 13 minutes and 6 seconds
Running and plotting the test cases 5 minutes and 36 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow type override in := when i is just order()

1 participant