[kanon-yoneji]

概要 (Summary)

• fix: nginx の gzip が HTTP/1.0 のリクエストで効かない問題と、起動時の警告を直す #1920 の広場対応

Summary by Sourcery

Update Nginx configuration to improve HTTPS handling and compatibility with upstream HTTP/1.0 proxies.

Bug Fixes:

• Correct Nginx HTTPS and compression behavior for deployments behind HTTP/1.0 proxying.

Deployment:

• Update Nginx server and gzip configuration for TLS and proxy compatibility.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Nginx TLS listener syntax and adjusts gzip behavior for the upstream proxy’s HTTP/1.0 forwarding, while narrowing the MIME types eligible for compression.

File-Level Changes

Change	Details	Files
Modernize the HTTPS listener configuration and align gzip negotiation with the HTTP version used by the upstream proxy.	Replace the deprecated separate ssl on directive with listen 443 ssl. Set gzip HTTP-version handling to 1.0 to support requests forwarded by the upstream proxy. Remove application/octet-stream and text/html from the gzip MIME type allowlist, disabling compression for those content types.	nginx/weko.conf

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 02da9b0c-e2cc-44e0-8170-29416debc925

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="nginx/weko.conf" line_range="344" />
<code_context>
 	gzip on;
 	gzip_disable "msie6";
-	gzip_http_version 1.1;
+	gzip_http_version 1.0; # 前段のプロキシは既定で HTTP/1.0 で転送してくる
 	gzip_comp_level 5; # or anything between 4-6
 	gzip_min_length 100;
</code_context>
<issue_to_address>
**HTTP/1.0 clients gain compression oracle**

When an attacker can induce an HTTP/1.0 proxied request whose response contains both a secret and attacker-controlled reflected data, nginx compresses the response, making its TLS ciphertext length vary with guesses about the secret; an attacker can use those lengths as a BREACH-style oracle to recover it.

Exclude sensitive responses from compression or ensure secret-bearing responses do not reflect attacker-controlled data.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: nginx/weko.conf:344

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[sourcery-ai]

🟡 Medium · HTTP/1.0 clients gain compression oracle

When an attacker can induce an HTTP/1.0 proxied request whose response contains both a secret and attacker-controlled reflected data, nginx compresses the response, making its TLS ciphertext length vary with guesses about the secret; an attacker can use those lengths as a BREACH-style oracle to recover it.

Exclude sensitive responses from compression or ensure secret-bearing responses do not reflect attacker-controlled data.

Prompt for AI agents

In `nginx/weko.conf` at line 344:

**HTTP/1.0 clients gain compression oracle**

When an attacker can induce an HTTP/1.0 proxied request whose response contains both a secret and attacker-controlled reflected data, nginx compresses the response, making its TLS ciphertext length vary with guesses about the secret; an attacker can use those lengths as a BREACH-style oracle to recover it.

Exclude sensitive responses from compression or ensure secret-bearing responses do not reflect attacker-controlled data.