Skip to content

🌐 [translation-sync] Read test_pwt.csv from data-lectures (Track D) - #92

Merged
mmcky merged 4 commits into
mainfrom
translation-sync-2026-08-18T01-14-31-pr-612
Aug 18, 2026
Merged

🌐 [translation-sync] Read test_pwt.csv from data-lectures (Track D)#92
mmcky merged 4 commits into
mainfrom
translation-sync-2026-08-18T01-14-31-pr-612

Conversation

@mmcky

@mmcky mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#612 - Read test_pwt.csv from data-lectures (Track D)

Files Updated

  • ✏️ lectures/pandas.md
  • ✏️ .translate/state/pandas.md.yml
  • ✏️ lectures/polars.md
  • ✏️ .translate/state/polars.md.yml

Details

  • Source Language: en
  • Target Language: zh-cn
  • Model: claude-sonnet-5

This PR was created automatically by the translation action.

@mmcky
mmcky requested a lite review from Copilot August 18, 2026 01:14
@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Aug 18, 2026
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-08-18
Routing: editor — 1 minor finding(s) in gating categories (accuracy/terminology/syntax/diff-check/other)
Shadow gate: would NOT auto-merge (recorded only; no action taken)


📝 Translation Quality

Criterion Score
Accuracy 9/10
Fluency 9/10
Terminology 9/10
Formatting 8/10
Overall 8.9/10

Summary: The translation of the changed sections in pandas.md and polars.md is accurate, fluent, and terminologically consistent with the provided glossary. No MyST/Markdown syntax errors were found. Minor points include inconsistent treatment of plot label strings inside code cells between the two files and an added font-configuration code block in pandas.md not present in the source, which may reflect a project-wide i18n convention but is worth confirming. Technical vocabulary (惰性求值, 谓词下推, 投影下推, 列表达式, etc.) is translated accurately and consistently with standard Chinese data-engineering terminology. Complex multi-clause English sentences in the Overview and Performance comparison sections are broken down into natural, readable Chinese sentences without losing technical precision. Code blocks, directive syntax ({code-cell}, {note}, {tip}, {exercise-start}, etc.) and cross-references are preserved correctly across both files. The added YAML 'translation' metadata block correctly maps headings per the sync system convention and does not interfere with document structure.

Suggestions:

  • [minor · formatting] lectures/pandas.md — ## Overview - import block: The translation adds extra code lines (matplotlib font configuration with '# i18n' comments) that are not present in the English source. While this may be part of an established i18n build convention across the repository, it constitutes added content relative to the source and should be verified as consistent with project-wide practice rather than an unintended deviation.
  • [minor · terminology] lectures/pandas.md — ### 标准化与可视化 - plot labels: Axis labels and titles inside plotting code (e.g., ax.set_xlabel('国家'), ax.set_ylabel('人均GDP'), plot title '美国失业率') were translated, whereas in polars.md the equivalent code-embedded strings (e.g., ax.set_xlabel('country'), ax.set_title('US Unemployment Rate')) were left in English. This creates an inconsistency in translation policy for in-code string literals between the two companion documents. → Adopt a consistent policy for translating (or not translating) string literals embedded in code cells across pandas.md and polars.md.
  • [nit · fluency] lectures/polars.md — ### 性能比较: In the performance comparison section, some print statement labels remain in English (e.g., 'Small data -- pandas:', 'pandas:', 'Polars eager:') while surrounding prose is fully translated. This is likely intentional since these are code/print outputs, consistent with not altering code, but flagged for awareness given the mixed treatment of embedded strings noted above.

🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 10/10

Summary: The translation sync correctly applied the URL/path changes for test_pwt.csv in both pandas.md and polars.md at all matching locations without altering headings or structure.


This review was generated automatically by action-translation review mode.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This translation-sync PR updates the zh-cn lecture content to match upstream changes from QuantEcon/lecture-python-programming#612, switching the Penn World Tables example CSV source to the QuantEcon/data-lectures repository and aligning the Polars performance example’s RNG usage with upstream.

Changes:

  • Update test_pwt.csv download URLs in both pandas and polars lectures to https://github.com/QuantEcon/data-lectures/raw/main/lectures/test_pwt.csv
  • Adjust the pandas lecture text to reference test_pwt.csv (no longer pandas/data/test_pwt.csv)
  • Update Polars benchmark snippet to use np.random.default_rng(42) instead of global np.random.seed

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lectures/pandas.md Updates the PWT CSV reference and read URL to the new data-lectures location.
lectures/polars.md Updates the PWT CSV read URL in multiple cells and modernizes random number generation in the benchmark example.
.translate/state/pandas.md.yml Advances translation sync metadata (source SHA, sync date, tool version).
.translate/state/polars.md.yml Advances translation sync metadata (source SHA, sync date, tool version).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmcky
mmcky force-pushed the translation-sync-2026-08-18T01-14-31-pr-612 branch from e7a9724 to 399622a Compare August 18, 2026 03:11
@mmcky

mmcky commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

♻️ Automatically rebased after #89 was merged.

Overlapping files: lectures/pandas.md, lectures/polars.md

The translation content is preserved; only unchanged sections were updated to match the current main branch. Please re-review if needed.

@mmcky
mmcky merged commit 9d543a5 into main Aug 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants