Repository navigation
[Fix] Accept parenthesized ClickHouse record keys - #169
Merged
Merged
Conversation
Samfisheryu
approved these changes
Oct 25, 2026
Samfisheryu
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed for correctness, performance, and clean-slate design. No blocking implementation issues found. The normalization preserves strict identifier and key-order validation, and parsing remains confined to startup schema checks.
Local validation: 72 tests passed — 41 parser, 10 schema/format, 14 record-storage against ClickHouse 25.12, and 7 HTTPS tests. The record-storage tests used a freshly built host backend, with the full-backend availability guard redirected to that verified build for this run. A focused check of the TLS terminator's untrusted and trusted paths also passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse 26.11.1.738 renders a single-column primary or sorting key as
(model_id), where 25.12.2.54 rendersmodel_id. DMI's live-table validator rejected the parenthesized form, so a valid single-key record layout failed initialization before the insert stage became ready.Accept both forms for primary keys and sorting keys while retaining strict identifier-list validation.
Implementation details
The Ubuntu 26.04 CI run also exposed two existing TLS-test assumptions. Its libcurl 8.18.0 OpenSSL backend can finish the TLS handshake and then reject certificate trust before sending HTTP data, so a server-side failed-handshake count is not a portable verification result. The tests now require certificate rejection, one connection without retries, and no request or application bytes; the trusted-CA capture round trip still runs. This changes test instrumentation and assertions only; the runner selection and production TLS verification are unchanged.
Compatibility
Verified against ClickHouse 25.12.2.54 and 26.11.1.738. Table DDL, record schemas, public APIs, and stored data formats are unchanged. Existing checks for column types/order, primary keys, sorting keys, and index granularity remain active.
Validation
Reproduced from current
main(e98a9ff) in a separate clone and Conda environment. Both ClickHouse test instances used separate data directories and ports; the existing server was left running.git diff --check: passed.Setup: Python 3.12.15 and PyTorch 2.14.1+cpu. Storage tests exercised the compiled
DMXHostEnginehost backend, with their full-backend availability guard locally redirected to the verified host build. The local build supplied the existing host link's missinglibcryptodependency; no build-system change is included. No training or GPU execution was needed for this storage-validation regression.TLS-test compatibility validation:
Full CI run passed on commit
9960491: