You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Stage 1 to Stage 3 silently plans a PromQL root whose series-identity rewrite fails #784
For every PromQL root, Stage 1 to Stage 3 adds the series identity (with_promql_series_identity) so that each output row carries its series' labels. If the rewrite fails, the error is dropped and the root is planned unchanged:
A root whose identity rewrite fails is then planned without per-series identity, and nothing reports it. The Planner's own executor treats the same failure as an error (promql_rows). ASAPQuery-backend's control plane used to refuse such roots too, before it switched to plan_installable. Now it can no longer see the failure.
Expected
A failed series-identity rewrite fails planning for that query with a named error. Unchanged roots are not silently accepted.
Acceptance
A test with a PromQL root whose rewrite fails returns the error from e2e_plan and from plan_installable.
Activity