You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Preserve PromQL bool comparison modifier in pre-ASAP IR #306
The pre-ASAP IR should preserve the bool comparison modifier. A normal vector comparison filters out non-matching series, while a bool comparison retains matching series with a 0/1 value. These are different query semantics.
Steps to reproduce
Run the PromQL corpus pre-ASAP dump command.
Compare the per-query IR dumps for left_vector == fill(30) right_vector and left_vector == bool fill(30) right_vector.
Observe that both have the same BinaryOp, comparison operator, operands, and vector matching metadata; no return-bool information is present.
Additional context
The corpus records are testdata queries 338 and 341. The dump also shows that the fill(30) modifier is absent from both IRs; this may be a separate or related unsupported modifier issue and should be assessed while fixing the bool distinction.
Activity