You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Changes tenant-switch storage behavior in worker processes; incorrect flushing could misroute reads/writes across tenant and landlord storage.
Overview
Fixes tenant isolation for file I/O in long-lived Horizon/Octane workers where Laravel’s FilesystemManager kept cached disk adapters pointed at the previous root even after multitenancy config was rewritten.
SwitchTenant now calls a new flushFilesystemDisks helper after tenant disk roots (and lang disk) are updated in makeCurrent, and again when forgetCurrent restores landlord filesystems.disks roots/URLs before other teardown. Flushing uses Storage::forgetDisk and drops the filesystem container binding so the next Storage::disk() resolves the correct tenant or landlord path.
A unit test warms the landlord local disk, switches to a fake tenant, asserts paths under storage/tenant_{id}, and verifies forgetCurrent restores the original landlord path.
Reviewed by Cursor Bugbot for commit 6ff4554. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix filesystem caching issue caught by nightly testbench
ci:deploy
ci:run-testbench