Fix ClickHouse lookup pagination for UNION queries - #958
Open
CheekyNox wants to merge 1 commit into
Open
Conversation
CheekyNox
force-pushed
the
fix/clickhouse-union-pagination
branch
from
August 21, 2026 04:14
4cd6b56 to
b236f2f
Compare
CheekyNox
force-pushed
the
fix/clickhouse-union-pagination
branch
from
August 21, 2026 04:22
b236f2f to
00bba76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
ClickHouse lookups that combine multiple event families append pagination directly after a multi-branch
UNION ALL. The trailingLIMITdoes not constrain the complete union, so a lookup configured for a few lines can return thousands of rows and flood the Minecraft client chat.Applying an outer
ORDER BY ... LIMIT ... OFFSET ...directly to the full rows fixes the result count but makes deep pages materialize large item/container payload expressions before pagination. On large histories this can exceed the ClickHouse memory limit.Fix
For paginated ClickHouse detail lookups:
tbl,id, andtimeacross the candidate sources and apply global ordering/pagination.This keeps pagination global while avoiding materialization of binary payloads for discarded rows. Non-ClickHouse lookup paths are unchanged.
Verification
mvn verify(BUILD SUCCESS; tests are skipped by the upstream Maven configuration)