Skip to content

馃┕ [Patch]: Fonts uses the current module workflow contract - #72

Draft
Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
mainfrom
fonts-contract-alignment
Draft

Marius Storhaug (MariusStorhaug) wants to merge 3 commits into
mainfrom
fonts-contract-alignment

Conversation

@MariusStorhaug

@MariusStorhaug Marius Storhaug (MariusStorhaug) commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Fonts now follows the current Process-PSModule repository contract with a reproducible workflow reference, repository-local contributor and agent guidance, and a working Zensical documentation site. Test and automation changes exercise the existing pipeline. Module commands and Windows PowerShell 5.1 support remain unchanged.

Adopting this release

No configuration, code, or invocation changes are required for module consumers. Windows PowerShell 5.1 remains the declared minimum runtime. Contributors should read CONTRIBUTING.md for the approved runtime compatibility exception and safe font-test isolation.

Release impact

The existing Patch label selects patch impact under Process-PSModule v8. Final release coordinates are resolved by the release process. No prerelease is requested. This PR remains a draft for the maintainer to move to ready manually.


Technical details

Consumer change record

The Fonts command surface, per-file dependency declarations, and supported runtime contract are unchanged. No module consumer action is required.

Repository integration now pins Process-PSModule v8.0.7 to 105e4dcefe1946782066aa50a5c7d3658319895a, with a trailing version comment for Dependabot. Caller triggers, permissions, secrets, and concurrency are unchanged. ImportantFilePatterns retains source and README defaults and adds tests, workflow/settings files, linter settings, and the Zensical configuration. The coverage target remains 80%, and existing linter overrides are preserved.

Template baseline

Surface Immutable baseline and evidence
Producer Process-PSModule v8.0.7, the resolved current release.
Integration template Template-PSModule, including its .github/zensical.toml. Fonts supplies its own identity and retains expanded navigation and consent settings.
Repository standard Canonical repository standard and organization community files.
Compatibility evidence Exact pinned framework build, help generation, and site assembly pass locally; strict Zensical build and the CI module/docs/site jobs pass.
Template work No upstream template change is required for this consumer alignment. Fonts documents its approved PowerShell 5.1 exception locally.

Maintainer evidence

  • Adds root CONTRIBUTING.md, SECURITY.md, SUPPORT.md, CODE_OF_CONDUCT.md, AGENTS.md, and CLAUDE.md, plus .github/pull_request_template.md. Fonts has no managed-file subscriptions; these are repository-local files. Contributor Covenant attribution and licensing are retained.
  • Documents that the PowerShell 5.1 exception overrides the framework's latest-LTS-only runtime policy. Build/test tooling requirements do not raise the module's minimum runtime.
  • Replaces the inactive MkDocs configuration with .github/zensical.toml, using the pinned release's actual .PSModule/site/docs staging contract and framework-owned shared-script injection. The icon stays local. Generated .PSModule/ output is ignored.
  • Keeps the README's module usage and platform information, adds the minimum runtime and generated-help entry points, and moves generic contribution instructions into the repository-local guide.
  • The PR template's H1-only Markdown rule is scoped out because GitHub supplies the title and the template is a body fragment; other Markdown rules remain active.
  • src/ and tests/ are byte-for-byte unchanged from main commit 16fb73132299658160e2189433bb1632fe8b1f32. No font behavior fixes or behavioral tests from 馃 [Fix]: Forced reinstalls and CI checks are repaired聽#70 are imported.
Validation Result
Workflow, configuration, and Markdown actionlint, repository-configured Markdown lint, generated-help lint, YAML/TOML parsing, important-path matching/exclusions, and git diff --check pass.
Compiled artifact Exact v8.0.7 build passes. Manifest retains PowerShell 5.1 and Desktop support and collects the existing Admin dependency from per-file #Requires. Source and compiled module pass static PowerShell 5.1 syntax checks.
Local behavioral suite All 10 existing Pester 6.1.0 tests pass on PowerShell 7.6.1/macOS with font paths redirected to session-owned temporary directories. Real user/system font directories and registry entries are untouched.
Documentation Exact framework help generation/site assembly and Zensical 0.0.72 strict build pass. Four expected pages, 64 local navigation/asset/fragment links, icon identity, runtime text, theme fonts, and consent content are verified.
PR CI Module build, repository/source/module lint, source/module/Fonts tests on Linux/macOS/Windows, test-result aggregation, documentation build, and site build pass. Publishing is skipped.
Actual Windows PowerShell 5.1 Not executed on this macOS host. Current-PowerShell CI and static checks are not minimum-runtime execution evidence.

Existing merge blocker: CI coverage is 70.8%, below the unchanged 80% target. The same-day main baseline reports the identical 70.8% failure and also fails site assembly because the Zensical configuration is missing. This PR repairs the site failure. Coverage expansion remains in #70; this PR does not lower or skip the gate.

Copilot review completed with no inline findings. Its request for workflow/site validation is addressed by the evidence above.

Relevant issues (or links)

Related work

@psmodule-s-shelly

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

Pattern Description
^src/ Matches files where path matches this pattern
^README\.md$ Matches files where path matches this pattern

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

@MariusStorhaug Marius Storhaug (MariusStorhaug) added Patch github_actions Pull requests that update GitHub Actions code documentation Improvements or additions to documentation labels Oct 26, 2026
@psmodule-s-shelly

Copy link
Copy Markdown

No Significant Changes Detected

This PR does not contain changes to files that would trigger a new release:

Pattern Description
^src/ Matches files where path matches this pattern
^README\.md$ Matches files where path matches this pattern

Build, test, and publish stages will be skipped for this PR.

If you believe this is incorrect, please verify that your changes are in the correct locations.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃數 Needs a closer look

End-to-end workflow and staged Zensical build validation remain unconfirmed for this build-and-release integration change.

No open issues 馃帀

What changed in this PR

This PR aligns Fonts with the current Process-PSModule workflow contract while preserving Windows PowerShell 5.1 support. It remains separate from the font behavior fixes in #70.

Changes:

  • Pins Process-PSModule to the immutable v8.0.7 commit and expands important-file detection while retaining the 80% coverage target.
  • Replaces MkDocs configuration with a standalone Zensical configuration.
  • Adds repository governance, contributor guidance, and agent onboarding without changing module commands.
File Description
SUPPORT.md Defines support channels and reporting guidance.
SECURITY.md Documents supported versions and private vulnerability reporting.
README.md Clarifies minimum runtime and documentation access.
CONTRIBUTING.md Defines contribution, compatibility, and isolated-validation requirements.
CODE_OF_CONDUCT.md Adds community conduct and enforcement guidance.
CLAUDE.md Points to shared agent guidance.
AGENTS.md Establishes standards, compatibility, and test-safety guidance.
.gitignore Excludes generated .PSModule/ artifacts.
.github/鈥媧ensical.toml Adds standalone documentation-site configuration.
.github/鈥媤orkflows/鈥婸rocess-PSModule.yml Pins the reusable workflow to v8.0.7鈥檚 commit.
.github/鈥媝ull_request_template.md Adds a shared pull request structure.
.github/鈥婸SModule.yml Expands important-file patterns and preserves coverage settings.
.github/鈥媘kdocs.yml Removes the superseded documentation configuration.

Review effort: Balanced

@MariusStorhaug

Copy link
Copy Markdown
Member Author

The workflow and staged-site validation requested in the review are now recorded in the PR description. At head 392aebd, CI passes the module build, repository/source/module lint, source/module/Fonts tests on Linux/macOS/Windows, documentation build, and site build. The local strict Zensical build also passes, including four expected pages and 64 checked local links; all 10 existing Pester tests pass with session-owned font directories.

The only failing CI gate is coverage: 70.8% against the unchanged 80% target. The main baseline has the identical coverage failure. The expanded behavioral tests remain in #70. The compiled manifest retains PowerShell 5.1 and Desktop support; actual Windows PowerShell 5.1 execution remains unverified on this macOS host. This PR stays draft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code Patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants