Repository navigation
RDODCP-1692: log refused outbound connections at info level - #66
Merged
Merged
Conversation
With --disable-forward, refused outbound channels were only logged at debug level, so they never showed up without -v. Log them at info level with the requested target, quoted because it comes from the client.
The exact log match already proves the refusal is logged on a single line.
samartha-pm
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the server runs with
--disable-forward, refused outbound channels were only logged withDebugf, so they never showed up unless the server runs with-v. They are now logged at info level, with the requested target:%q): a value containing newlines can't add fake lines to the log.Open (user=… addr=… remotes=…)line, already at info level, identifies who attempted it.Changes
share/tunnel/tunnel_out_ssh.go:Debugf("Denied outbound connection")→Infof("Denied outbound connection to %q", target)share/tunnel/tunnel_out_ssh_test.go: new unit testREADME.md: changelog lineValidation
Debugf.go vetis clean; theserver,share/tunnelandtest/e2etests pass. The fullgo test ./...has the same 4 failing tests asmaster(keepalive and retry-interval), nothing new.--reverse --disable-forwardand no-v, a client with a forward remote, one request through it → the server logstun: Denied outbound connection to "127.0.0.1:18181".Follow-up
v1.12.0-os.4